Re: Re: Re: Re: Re: Re: Re: [PATCH 0/2] Power management fixes

[Niklas Cassel <cassel@kernel.org>]

Hello Dieter,

On Thu, Feb 08, 2024 at 03:37:48PM +0100, Dieter Mummenschanz wrote:

> > I assume that you didn't need this on v6.6 and older?
> 
> > (Instead libata should put the device to standby or sleep itself,
> > it shouldn't need to be done explicitly by the user.)
> 
> I'm at a loss either. No idea why this is actually working. When I encountered the low-power issue I searched the web and stumbled upon hdparm -Y and gave it a shot.

Are you saying that you always do this before suspending?
Both on v6.6 and v6.7?


> > But if you can enter pc8 on every boot on v6.6, but not on v6.7,
> > then it is probably easier to figure out which commit that broke
> > things, as there were not that many suspend/resume related changes
> > added in v6.7.
> 
> Maybe you could point them out so I can try to bisect?

Sure.

These are the libata (and related SCSI) patches added in v6.7
(that are not in v6.6):

b09d7f8fd50f scsi: sd: Fix system start for ATA devices
6371be7aeb98 scsi: Change SCSI device boolean fields to single bit flags
fd3a6837d8e1 ata: libata-core: Fix ata_pci_shutdown_one()
2da4c5e24e86 ata: libata-core: Improve ata_dev_power_set_active()
54d7211da7cd ata: libata-eh: Spinup disk on resume after revalidation
1b947279798f ata: libata: Cleanup inline DMA helper functions
0fecb50891aa ata: libata-eh: Reduce "disable device" message verbosity
7f95731c74d7 ata: libata-eh: Improve reset error messages
88b9f8928678 ata: libata-sata: Improve ata_sas_slave_configure()
3341b82368fb ata: libata-core: Do not resume runtime suspended ports
3a94af2488bf ata: libata-core: Do not poweroff runtime suspended ports
09b055cfb0e9 ata: libata-core: Remove ata_port_resume_async()
6702255d700a ata: libata-core: Remove ata_port_suspend_async()
5b6fba546da2 ata: libata-core: Detach a port devices on shutdown
cfead0dd81de ata: libata-core: Synchronize ata_port_detach() with hotplug
8c1f08170694 ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat()
c4367ac83805 scsi: Remove scsi device no_start_on_resume flag

I would start with v6.6 and apply them one by one.
(Starting with c4367ac83805)

However, it is also possible that the regression is completely unrelated
to libata changes (e.g. caused by a ACPI suspend/resume patch), and in
that case, you will need a complete bisection.


Kind regards,
Niklas