Re: Fwd: Re[2]: ASMedia ASM1166/ASM1064 port restrictions will break cards with port-multipliers

[Niklas Cassel <cassel@kernel.org>]

Hello Matt,

On Sun, Mar 17, 2024 at 11:58:14PM +0100, Cryptearth wrote:
> Sorry folks - GMail somehow not send my reply to all of you but only
> one. My bad - haven't noticed it.
> 
> Anyway - tldr: The provided patch doesn't work.
> I build the 6.8.1-arch with a simple fix of commenting out the ASMedia block.
> No matter how it's dealt with - I do understand the issue this change
> is about to fix - but there has to be some override. Forcing users
> like me building the entire kernel (and additional modules like ZFS or
> nVidia gpu drivers) on thier own just for 4 characters in 2 lines
> (namely /* and */ before and after the block) just isn't acceptable.
> 
> Greetings
> 
> Matt
> 
> ---------- Forwarded message ---------
> Von: Cryptearth <cryptearth@googlemail.com>
> Date: Sa., 16. März 2024 um 14:47 Uhr
> Subject: Re: Re[2]: ASMedia ASM1166/ASM1064 port restrictions will
> break cards with port-multipliers
> To: Conrad Kostecki <conikost@gentoo.org>

Please be respectful on the mailing list.
https://docs.kernel.org/process/code-of-conduct.html


> @Niklas
> I tested the patch - but unfortunately it does not work with my card.
> See the attached log - the fun starts around line 760. This time I
> also attached the output of lspci -vvv -nn. I haven't checked for any
> differences.
> As Hans wrote my card seem to do something way different and out of
> spec of standards.

Is CONFIG_SATA_PMP set to y in your .config?


Looking at your logs, we can see that port0-port3 all don't have a link:
[    0.919020] ata7: SATA link down (SStatus 0 SControl 330)
[    2.787201] ata8: SATA link down (SStatus 0 SControl 330)
[    3.100522] ata9: SATA link down (SStatus 0 SControl 330)
[    3.413890] ata10: SATA link down (SStatus 0 SControl 330)

I looked at your v6.7.xx log as well, and it is the same there.

So Hans's theory that port0-port3 is each connected to a
JMB575 Port Multipliers does seem less plausible.

Because if that was the case, I would expect to see link up on these ports
and that it detects a PMP class code when probing these ports.

So I have honestly no idea how this works...

Perhaps the ASMedia firmware takes the command to port0-port3,
and instead of sending it to the PMP, it sends back some faked
reply instead?

This piece of hardware really seems to do not care at all about
following specifications...

Fun fact:
https://www.asmedia.com.tw/product/A58yQC9Sp5qg6TrF/58dYQ8bxZ4UR9wG5
Claims that it supports AHCI 1.4.
That is impressive, especially considering that the latest version
of AHCI is 1.3.1:
https://en.wikipedia.org/wiki/Advanced_Host_Controller_Interface

I will send an email to some ASMedia developers on the list and see
if we can get any clarification.


Kind regards,
Niklas