From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: libata-core: Remove ata_exec_internal_sg()
Date: Fri, 12 Apr 2024 13:59:20 +0200 [thread overview]
Message-ID: <ZhkiGJAzXjn6cc2s@ryzen> (raw)
In-Reply-To: <20240412001528.964063-1-dlemoal@kernel.org>
On Fri, Apr 12, 2024 at 09:15:28AM +0900, Damien Le Moal wrote:
> ata_exec_internal() is the only caller of ata_exec_internal_sg() and
> always calls this function with a single element scattergather list.
> Remove ata_exec_internal_sg() and code it directly in
> ata_exec_internal(), simplifying a little the sgl handling for the
> command.
>
> While at it, change the function signature to use the proper enum
> dma_data_direction type for the dma_dir argument, cleanup comments
> (capitalization and remove useless comments) and change the variable
> auto_timeout type to a boolean.
>
> No functional change.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
prev parent reply other threads:[~2024-04-12 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 0:15 [PATCH v2] ata: libata-core: Remove ata_exec_internal_sg() Damien Le Moal
2024-04-12 11:59 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhkiGJAzXjn6cc2s@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).