From: Niklas Cassel <cassel@kernel.org>
To: dev@kayoway.com
Cc: dlemoal@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 0/1] ata: ahci: Revert "ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list"
Date: Tue, 21 May 2024 14:54:34 +0200 [thread overview]
Message-ID: <ZkyZiodz16XQO32_@ryzen.lan> (raw)
In-Reply-To: <20240517053902.44622-1-dev@kayoway.com>
On Fri, May 17, 2024 at 02:39:01PM +0900, dev@kayoway.com wrote:
> From: Jason Nader <dev@kayoway.com>
>
> Changes - updated commit message as per the kind guidance from Niklas.
>
> I was not sure whether to cc stable, but if so it would allow affected
> users to start to be able to use kernel versions > 6.6.10.
>
> Below are logs including the extra logging asked for by Niklas.
>
> Kernel logs with this patch:
> >journalctl --boot 0 | rg 'Linux version|SATA|external port'
> Linux version linux6.9.disableAlderLakequirk@archlinux
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
Since the prints below are for ata5-ata8, that most likely means that the
"external port, not enabling LPM" prints above are for port ata1-ata4,
so they are not really relevant and might even belong to a different SATA
controller.
Anyway, lpm-policy for ata5-ata8 is the same before and after this patch,
so everything looks fine.
Kind regards,
Niklas
> ahci 0000:00:17.0: AHCI vers 0001.0301, 32 command slots, 6 Gbps, SATA mode
> ata5: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802300 irq 125 lpm-pol 3
> ata6: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802380 irq 125 lpm-pol 3
> ata7: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802400 irq 125 lpm-pol 3
> ata8: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802480 irq 125 lpm-pol 3
> ata5: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
> ata8: SATA link down (SStatus 0 SControl 300)
> ata6: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
> ata7: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
>
> Kernel logs without this patch:
> >journalctl --boot 0 | rg 'Linux version|SATA|external port'
> Linux version linux6.9.enableAlderLakequirk@archlinux
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
> ata4294967295: external port, not enabling LPM
> ahci 0000:00:17.0: AHCI vers 0001.0301, 32 command slots, 6 Gbps, SATA mode
> ata5: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802300 irq 125 lpm-pol 3
> ata6: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802380 irq 125 lpm-pol 3
> ata7: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802400 irq 125 lpm-pol 3
> ata8: SATA max UDMA/133 abar m2048@0x80802000 port 0x80802480 irq 125 lpm-pol 3
> ata8: SATA link down (SStatus 4 SControl 300)
> ata5: SATA link down (SStatus 4 SControl 300)
> ata6: SATA link down (SStatus 4 SControl 300)
> ata7: SATA link down (SStatus 4 SControl 300)
next prev parent reply other threads:[~2024-05-21 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 13:53 [PATCH] ata: ahci: Revert "ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list" dev
2024-05-13 13:53 ` [PATCH 1/1] " dev
2024-05-15 17:47 ` Niklas Cassel
2024-05-15 17:19 ` [PATCH] " Niklas Cassel
2024-05-17 5:39 ` [PATCH v2 0/1] " dev
2024-05-17 5:39 ` [PATCH v2 1/1] " dev
2024-05-21 12:55 ` Niklas Cassel
2024-05-21 13:13 ` Niklas Cassel
2024-05-21 12:54 ` Niklas Cassel [this message]
2024-05-21 13:36 ` [PATCH v3] ata: ahci: Do not apply Intel PCS quirk on Intel Alder Lake Jason Nader
2024-05-27 8:12 ` Niklas Cassel
2024-05-30 14:11 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkyZiodz16XQO32_@ryzen.lan \
--to=cassel@kernel.org \
--cc=dev@kayoway.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).