From: Niklas Cassel <cassel@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: "Damien Le Moal" <dlemoal@kernel.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-scsi: Set the RMB bit only for removable media devices
Date: Fri, 14 Jun 2024 14:03:12 +0200 [thread overview]
Message-ID: <ZmwxgBHXHv8iKjFv@ryzen.lan> (raw)
In-Reply-To: <60f1465f-c4da-5d0f-e395-8457a9287996@gmail.com>
On Thu, Jun 13, 2024 at 10:00:30PM +0300, Sergei Shtylyov wrote:
> > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> > index cdf29b178ddc..e231ad22f88a 100644
> > --- a/drivers/ata/libata-scsi.c
> > +++ b/drivers/ata/libata-scsi.c
> > @@ -1831,11 +1831,11 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf)
> > 2
> > };
> >
> > - /* set scsi removable (RMB) bit per ata bit, or if the
> > - * AHCI port says it's external (Hotplug-capable, eSATA).
> > + /*
> > + * Set the SCSI Removable Media Bit (RMB) if the ATA removable media
> > + * device bit (which is only defined in the CFA specification) is set.
>
> It used to be defined since ATA-1; I think it was only obsoleted by ATA-8 ACS...
Looking at the t13 achives, it was obsoleted by:
e06116r0: Obsolete removable media related feature sets
in 2006, ATA-8 ACS (i.e. ACS-1).
I will update the comment accordingly and send out a v2.
Kind regards,
Niklas
prev parent reply other threads:[~2024-06-14 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 17:33 [PATCH] ata: libata-scsi: Set the RMB bit only for removable media devices Niklas Cassel
2024-06-13 17:35 ` Mario Limonciello
2024-06-13 17:40 ` Thomas Weißschuh
2024-06-13 17:44 ` Niklas Cassel
2024-06-13 17:49 ` Thomas Weißschuh
2024-06-13 18:00 ` Niklas Cassel
2024-06-13 19:00 ` Sergei Shtylyov
2024-06-14 12:03 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmwxgBHXHv8iKjFv@ryzen.lan \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=manuel.lauss@gmail.com \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox