From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC8C1113 for ; Wed, 26 Jun 2024 00:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719361842; cv=none; b=O8N/xVgXh2aEZdlLxb0yrnpKdB77jxeYiKExZAQkYHpcc0HHJuP82+2Tj4psVl4WbgnScJpxAap5A/IgCZUkLSkayA7B1DZZdzz7VWpO3vQuPCnTmqrO5HjX925T/xnXdJw6kFIWLeiWzQYhad7ZeYMqiG0DYgQ2mWvCMZcaLCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719361842; c=relaxed/simple; bh=//lbaRqY5eoLuH4cVGLi2EsZ7aNqiiSDMS7zZVy2wIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QM9jltv2yTND5j+mPEGmiCre79llOQ7rwWeyXe0bZA7qJe5M+msNQLGR509x+Axs/V7myjheV88r65A0aUSh/6zNvdH/oD6luGmd82Dma4wQuVO/d1YNB2vBpbc7Mcu//DGCmvD9Y0O5Ah6xiVvmVIPokqn+yGqv8R5GZYGYEp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HVhVmB4n; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HVhVmB4n" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2c7dd54d3d2so4934538a91.2 for ; Tue, 25 Jun 2024 17:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719361841; x=1719966641; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=i23/JHna8Kw5DlU8qzmRWS+LzRQQ+oAyxg9Kg6RIE+I=; b=HVhVmB4nMUueVIppBPYhu3oj2poxdny/dxItr7vGadnFfT7Vs9vDkpXjfwf8L99qhT D4lo9VXkZ6z48bWMUI8BcWzGwaW+HN8seLhz0g68GFqK2jwRapmrrCXgpY/wa8hQpJ1P I4XwZxgVbxbZEnfk0Cy9S810GcEzOfSfvje6tddHHN9nZRiuCKAFrVkvh0Y/Rft1VPEN 9h2JbJeTtO6qA/ZBW40qtk9acmL2gBuOpfQFpQblO3+RpZMdFvHBmiVvejHLZFj4Ekbu B5ZxOjnfH/IbwdCiUWAivZMyyNfGD7Cq/rDrbfsZXvka8FN4jxmy2Lzvw9Mm3Lc55ILs EckQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719361841; x=1719966641; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i23/JHna8Kw5DlU8qzmRWS+LzRQQ+oAyxg9Kg6RIE+I=; b=P7/1/F0b2ZRqfUp33/8gupMmWUZ3dITebZ+3J2U7mGLhrD9dZHGHWg/9QISwg4CSW5 0ZWttmS5kr5D27OeGU5kk7Px+1RtcZKiLMdKW4RU52mehO7o9T8Kna28rPoS1S9JCPbL veViDhhQNXRB+tbVeix8oTWJJFD5qdxnQllKX6jQSnKGT5DwlZYXuXxXRP00C44Oo7HU qyHgUogt2EWHyEZOp4HUD3B6yeatUzG+g/+4VIaUUjET/TGZWtyEMeftt+2Hj9zBcnI+ Cm2yZ+KScKYkZ1TBBqvHWSQ/ZJ4HxuytpYvDziiNajCWd84hIcHLpCklmuZ9t9ztBLLp XHpg== X-Forwarded-Encrypted: i=1; AJvYcCUkX8XakB44T9uJCI6lyGnIQ+FRIKZcP+rELjgBfvzB4GroPZAIMX7EYlm1aV2leiOqPIuQhIwozz7aNORfPyKNT7t6k/+nF5pH X-Gm-Message-State: AOJu0YwD4EtxqgXr2GnqCqZPpNr6PjbIrFHGJ/aVWaRPH0DKz+jgyy0p Q8CKyTd5UNYya9SRNrzMnyK61Sm/4jJ0FlXFCsoUmu1k12tI8zqJ2mfmDE4wAA== X-Google-Smtp-Source: AGHT+IFx/AHTzD88KwcwaUMpPa/wWT49rpSS1KTboIK2UJ56CegkPm+jg5af9OdvUO9x64xl23dIbw== X-Received: by 2002:a17:90b:4f8c:b0:2c7:aafb:8e3c with SMTP id 98e67ed59e1d1-2c861246c21mr8421073a91.18.1719361840450; Tue, 25 Jun 2024 17:30:40 -0700 (PDT) Received: from google.com (148.98.83.34.bc.googleusercontent.com. [34.83.98.148]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c8d81d29desm234795a91.53.2024.06.25.17.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 17:30:39 -0700 (PDT) Date: Wed, 26 Jun 2024 00:30:35 +0000 From: Igor Pylypiv To: Hannes Reinecke Cc: Damien Le Moal , Niklas Cassel , Tejun Heo , "Martin K. Petersen" , Jason Yan , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf Message-ID: References: <20240624221211.2593736-1-ipylypiv@google.com> <20240624221211.2593736-7-ipylypiv@google.com> <7d085940-2ad1-4f44-83bb-33d852e80da0@suse.de> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7d085940-2ad1-4f44-83bb-33d852e80da0@suse.de> On Tue, Jun 25, 2024 at 08:26:59AM +0200, Hannes Reinecke wrote: > On 6/25/24 00:12, Igor Pylypiv wrote: > > qc->result_tf contents are only valid when the ATA_QCFLAG_RTF_FILLED flag > > is set. The ATA_QCFLAG_RTF_FILLED flag should be always set for commands > > that failed or for commands that have the ATA_QCFLAG_RESULT_TF flag set. > > > > For ATA errors and ATA PASS-THROUGH commands the ATA_QCFLAG_RTF_FILLED > > flag should be always set. Added WARN_ON_ONCE() checks to generate > > a warning when ATA_QCFLAG_RTF_FILLED is not set and libata needs to > > generate sense data. > > > > Signed-off-by: Igor Pylypiv > > --- > > drivers/ata/libata-scsi.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > > index e5669a296d81..7a8a08692ce9 100644 > > --- a/drivers/ata/libata-scsi.c > > +++ b/drivers/ata/libata-scsi.c > > @@ -246,6 +246,9 @@ static void ata_scsi_set_passthru_sense_fields(struct ata_queued_cmd *qc) > > struct ata_taskfile *tf = &qc->result_tf; > > unsigned char *sb = cmd->sense_buffer; > > > > + if (WARN_ON_ONCE(!(qc->flags & ATA_QCFLAG_RTF_FILLED))) > > + return; > > + > > if ((sb[0] & 0x7f) >= 0x72) { > > unsigned char *desc; > > u8 len; > > @@ -928,6 +931,9 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) > > unsigned char *sb = cmd->sense_buffer; > > u8 sense_key, asc, ascq; > > + if (WARN_ON_ONCE(!(qc->flags & ATA_QCFLAG_RTF_FILLED))) > > + return; > > + > > /* > > * Use ata_to_sense_error() to map status register bits > > * onto sense key, asc & ascq. > > @@ -971,6 +977,10 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc) > > ata_scsi_set_sense(dev, cmd, NOT_READY, 0x04, 0x21); > > return; > > } > > + > > + if (WARN_ON_ONCE(!(qc->flags & ATA_QCFLAG_RTF_FILLED))) > > + return; > > + > > /* Use ata_to_sense_error() to map status register bits > > * onto sense key, asc & ascq. > > */ > > Hmm. Not sure if we really need the WARN_ON() here or whether a simple > logging message wouldn't be sufficient; after all, we continue fine here. > My worry about adding a simple log statement is that it might cause a log spam if things go wrong for some reason. This code is more like a "this should never happen" comment and we always expect ATA_QCFLAG_RTF_FILLED to be present when generating sense data based on ATA registers. If WARN_ON_ONCE() is too much for this case I guess we can just remove it and silently return? Damien, Niklas, what are your thoughts on this? Thanks, Igor > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Kernel Storage Architect > hare@suse.de +49 911 74053 688 > SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg > HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich >