* [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
@ 2024-07-12 18:57 Frank Li
2024-07-12 20:52 ` Niklas Cassel
2024-07-12 20:58 ` Niklas Cassel
0 siblings, 2 replies; 5+ messages in thread
From: Frank Li @ 2024-07-12 18:57 UTC (permalink / raw)
To: Damien Le Moal, Niklas Cassel, Rob Herring, Krzysztof Kozlowski,
Conor Dooley,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Add missing documented compatible strings 'fsl,ls1046a-ahci' and
'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
'fsl,ls1043a-ahci'.
Fix below CHECK_DTB warnings
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
Fixes: e58e12c5c34c ("dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format")
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- Add rob's review tag
- Sort compatible string list
- Add fix tag
- Add two warnings in commit message.
- Add - description: sata controller for ls1012a
Change from v1 to v2
- rework commit message to show fix CHECK_DTB warning.
---
.../devicetree/bindings/ata/fsl,ahci.yaml | 20 ++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
index 162b3bb5427ed..b58ea5a183082 100644
--- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
@@ -11,13 +11,19 @@ maintainers:
properties:
compatible:
- enum:
- - fsl,ls1021a-ahci
- - fsl,ls1043a-ahci
- - fsl,ls1028a-ahci
- - fsl,ls1088a-ahci
- - fsl,ls2080a-ahci
- - fsl,lx2160a-ahci
+ oneOf:
+ - description: sata controller for ls1012a
+ items:
+ - const: fsl,ls1012a-ahci
+ - const: fsl,ls1043a-ahci
+ - enum:
+ - fsl,ls1021a-ahci
+ - fsl,ls1028a-ahci
+ - fsl,ls1043a-ahci
+ - fsl,ls1046a-ahci
+ - fsl,ls1088a-ahci
+ - fsl,ls2080a-ahci
+ - fsl,lx2160a-ahci
reg:
minItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
2024-07-12 18:57 [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci Frank Li
@ 2024-07-12 20:52 ` Niklas Cassel
2024-07-12 20:59 ` Frank Li
2024-07-12 20:58 ` Niklas Cassel
1 sibling, 1 reply; 5+ messages in thread
From: Niklas Cassel @ 2024-07-12 20:52 UTC (permalink / raw)
To: Frank Li
Cc: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote:
> Add missing documented compatible strings 'fsl,ls1046a-ahci' and
> 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
> 'fsl,ls1043a-ahci'.
>
> Fix below CHECK_DTB warnings
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
These lines should have been wrapped to 75 lines IMO.
I will fixup when applying.
>
> Fixes: e58e12c5c34c ("dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format")
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v2 to v3
> - Add rob's review tag
> - Sort compatible string list
> - Add fix tag
> - Add two warnings in commit message.
> - Add - description: sata controller for ls1012a
>
> Change from v1 to v2
> - rework commit message to show fix CHECK_DTB warning.
> ---
> .../devicetree/bindings/ata/fsl,ahci.yaml | 20 ++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> index 162b3bb5427ed..b58ea5a183082 100644
> --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> @@ -11,13 +11,19 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - fsl,ls1021a-ahci
> - - fsl,ls1043a-ahci
> - - fsl,ls1028a-ahci
> - - fsl,ls1088a-ahci
> - - fsl,ls2080a-ahci
> - - fsl,lx2160a-ahci
> + oneOf:
> + - description: sata controller for ls1012a
SATA should have been capitalized.
I will fixup when applying.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
2024-07-12 20:52 ` Niklas Cassel
@ 2024-07-12 20:59 ` Frank Li
2024-07-12 21:15 ` Niklas Cassel
0 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2024-07-12 20:59 UTC (permalink / raw)
To: Niklas Cassel
Cc: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Fri, Jul 12, 2024 at 10:52:39PM +0200, Niklas Cassel wrote:
> On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote:
> > Add missing documented compatible strings 'fsl,ls1046a-ahci' and
> > 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
> > 'fsl,ls1043a-ahci'.
> >
> > Fix below CHECK_DTB warnings
> > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
> > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
>
> These lines should have been wrapped to 75 lines IMO.
> I will fixup when applying.
Thanks, according to my knowledge, computer generate warning, error, log...
doesn't require wrap.
It may impact my other patch. just want to make clear about this.
Frank
>
> >
> > Fixes: e58e12c5c34c ("dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format")
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Change from v2 to v3
> > - Add rob's review tag
> > - Sort compatible string list
> > - Add fix tag
> > - Add two warnings in commit message.
> > - Add - description: sata controller for ls1012a
> >
> > Change from v1 to v2
> > - rework commit message to show fix CHECK_DTB warning.
> > ---
> > .../devicetree/bindings/ata/fsl,ahci.yaml | 20 ++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> > index 162b3bb5427ed..b58ea5a183082 100644
> > --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> > +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> > @@ -11,13 +11,19 @@ maintainers:
> >
> > properties:
> > compatible:
> > - enum:
> > - - fsl,ls1021a-ahci
> > - - fsl,ls1043a-ahci
> > - - fsl,ls1028a-ahci
> > - - fsl,ls1088a-ahci
> > - - fsl,ls2080a-ahci
> > - - fsl,lx2160a-ahci
> > + oneOf:
> > + - description: sata controller for ls1012a
>
> SATA should have been capitalized.
> I will fixup when applying.
>
>
> Kind regards,
> Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
2024-07-12 20:59 ` Frank Li
@ 2024-07-12 21:15 ` Niklas Cassel
0 siblings, 0 replies; 5+ messages in thread
From: Niklas Cassel @ 2024-07-12 21:15 UTC (permalink / raw)
To: Frank Li
Cc: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Fri, Jul 12, 2024 at 04:59:38PM -0400, Frank Li wrote:
> On Fri, Jul 12, 2024 at 10:52:39PM +0200, Niklas Cassel wrote:
> > On Fri, Jul 12, 2024 at 02:57:40PM -0400, Frank Li wrote:
> > > Add missing documented compatible strings 'fsl,ls1046a-ahci' and
> > > 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
> > > 'fsl,ls1043a-ahci'.
> > >
> > > Fix below CHECK_DTB warnings
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
> >
> > These lines should have been wrapped to 75 lines IMO.
> > I will fixup when applying.
>
> Thanks, according to my knowledge, computer generate warning, error, log...
> doesn't require wrap.
Yes, that is correct, especially for critical things like a kernel oops etc.
In this case, I don't think a simple CHECK_DTB warning is critical enough to
warrant keeping a line length of 232 columns, but I agree that 'critical
enough' is subjective.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
2024-07-12 18:57 [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci Frank Li
2024-07-12 20:52 ` Niklas Cassel
@ 2024-07-12 20:58 ` Niklas Cassel
1 sibling, 0 replies; 5+ messages in thread
From: Niklas Cassel @ 2024-07-12 20:58 UTC (permalink / raw)
To: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-ide, devicetree, linux-kernel, Frank Li
Cc: imx
On Fri, 12 Jul 2024 14:57:40 -0400, Frank Li wrote:
> Add missing documented compatible strings 'fsl,ls1046a-ahci' and
> 'fsl,ls1012a-ahci'. Allow 'fsl,ls1012a-ahci' to fallback to
> 'fsl,ls1043a-ahci'.
>
> Fix below CHECK_DTB warnings
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible:0: 'fsl,ls1012a-ahci' is not one of ['fsl,ls1021a-ahci', 'fsl,ls1043a-ahci', 'fsl,ls1028a-ahci', 'fsl,ls1088a-ahci', 'fsl,ls2080a-ahci', 'fsl,lx2160a-ahci']
> arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: sata@3200000: compatible: ['fsl,ls1012a-ahci', 'fsl,ls1043a-ahci'] is too long
>
> [...]
Applied to libata/linux.git (for-6.11), thanks!
[1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci
https://git.kernel.org/libata/linux/c/6739fad4
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-12 21:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 18:57 [PATCH v3 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci Frank Li
2024-07-12 20:52 ` Niklas Cassel
2024-07-12 20:59 ` Frank Li
2024-07-12 21:15 ` Niklas Cassel
2024-07-12 20:58 ` Niklas Cassel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox