Re: [PATCH v3 2/6] ata: libata: Rename and cleanup ata_rwcmd_protocol()

Sergei Shtylyov
2022-10-27T09:43:26Z

Hello!

On 10/27/22 10:50 AM, Damien Le Moal wrote:

> Rename ata_rwcmd_protocol() to ata_set_rwcmd_protocol() to better
> reflect the fact that this function sets a task file command and
> protocol. The arguments order is also reversed and the function return
> type changed to a bool to indicate if the command and protocol were set
> corretly (instead of returning a completely arbitrary "-1" value.

Correctly. :-)

> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/ata/libata-core.c | 26 ++++++++++++++------------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 884ae73b11ea..56ddcbaa0c6f 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -574,17 +574,18 @@ static const u8 ata_rw_cmds[] = {
> };
>
> /**
> - * ata_rwcmd_protocol - set taskfile r/w commands and protocol
> + * ata_set_rwcmd_protocol - set taskfile r/w command and protocol
> + * @dev: target device for the tf

s/tf/taskfile/?

> * @tf: command to examine and configure
> - * @dev: device tf belongs to
[...]

MBR, Sergey