From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E61283FD7 for ; Mon, 25 Aug 2025 14:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756132692; cv=none; b=YL2f5aGuVL9hXxsF+WibcRYnllwpPOdQDswUZICdN4HoX/f633eKmfWeP4zyJAJkD471TCFbK7OMNq2rFHJehdAx0EiTQ+3d1jV6eiV067Ov+0tIPQ9YxlKwPwDRBVUOq2PHD4vyPgCd1BdRIL1hcR2tDj1lnuv17Pq0cj0JG00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756132692; c=relaxed/simple; bh=TwEGdMJ02/Thp7fjKDeGa7zfRw1/IePVwKEQmR37S58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=up60S3Jwx46oBpjpKfYAYxO6qJCJizDBS27G2Gds4PDCRsu40iOIBZFKK8ukevFl08OVQTgT+0hW+0lZx8RnGsxNOtH/QqxMHAwiHqULkGemsIislkaR0fuh5Q00hHaQgmKBKe4K6z66pXo5yKtTlHDCUbP3Jwo228AN0yiGLfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R8kCcC1e; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R8kCcC1e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756132689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=S1b1Qn5IdFgoYphqgj6hBBswyK4CJqNFMjotKKBhPlQ=; b=R8kCcC1eo7h+yrPuE7HTxudvT1jCQvLeEZ7xlaWUIWinsunXhNmpVKIYCyw1m/IirBqDdB pxg0F37ueXlI8PjtvFvgv3NSg+kH6QYASNtaNId++Y5VlvVoJ5H6DT+rUpa6SNtslpOsN3 ZqqZ+ErwLRjgTnOgiTf6BgTtN7Qpeeg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-oOA11mfoPSq6WYWtY-fzcA-1; Mon, 25 Aug 2025 10:38:07 -0400 X-MC-Unique: oOA11mfoPSq6WYWtY-fzcA-1 X-Mimecast-MFC-AGG-ID: oOA11mfoPSq6WYWtY-fzcA_1756132686 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3c79f0a5ff0so798647f8f.3 for ; Mon, 25 Aug 2025 07:38:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756132686; x=1756737486; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S1b1Qn5IdFgoYphqgj6hBBswyK4CJqNFMjotKKBhPlQ=; b=UQkHZjgMBcbjazmQkKCrSkD2pjNuAajCzxjBo9PS8Vm8ZeCsKC72Nm/J31eKHXbb54 S1vkJ2fi+3pnBKccJe/1FSDf4e0s3CPPbaDuHtZzo6Y6Gm6LS/LE13tXOzMNwC+QHDlM L9h9oolmXPpyLKD+HpeLjot8rhBVxe4+l68fSaG0vncrff6xi39v0fy8NW+RmtVgdMWn sxTWnd//876xg/XHOMsQP6EZK4c6cAhN0Z6ravZeYdt7CgiTwfNwR8J0G9z/eISjFnsX TGxZ6A0FXGy8h7Flg0g4ZF4Zyv1zFXL1TF3mjOH/iD+JXaIm1xWDSvsGjJM3Sl28TLmL ZQNA== X-Forwarded-Encrypted: i=1; AJvYcCVr+LPuNs+cmiXcH0IEOAtQb7nbwI9SucGhZT8WktKrEc8dA+W1439wcOans5T9disWMzbD+AsCmXg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGFyruF/BLkNDY00mdDP1gvQgMGo4xv9yovU+MZmXCjhsNYPDb lR9q+Qdn7JIvfUKTDuxl1L9l7pd2NURHy1f85lXli8hKpH+aYTvPjFj0iMeS6+dEKqGcQ4++xyW f+1Z2F3SuHFuWpVvcXc4vciBIiHEU19buQyHcjkDoUF1W0LI+hWJE53eCzCjYAA== X-Gm-Gg: ASbGncuM8fQrxLI6kJihs7J/q9Vzpf0OXJ6qE6DKa9webi15KJ9rSMVDIZ3CeCIHP0h AOJhIf+5aDx31tZfNdfz3uXnnclEXFDgy+fGGLu6rSnJv82tODVxl1r/Xs+YbA1P+a1xhSV/5Wa H/RGwEUE1i5KXoElf3Vw0LWkY7QbRYnwfKL3gTh+gU+nL4o613ip79YGuvgTSbiecNXrHz0JR6F 1r6nbQtbPoqmbYzwXHZlZnMbIHJMiH2H/Joh2J8ElMkJTTxxkZmY5+aOQvlS1XJRDKx0qjp5E2T iXeg4YyFE6WAnO7Rmm1KyYJ9zzbCUAP+yFpMh3p5qn+Z7FhfitMiitykjdpj/RoCYgiG7/cA1K3 +6k7TVV0OAfgLPYjPbcUDK3w/KkImbWW7tkj5hwwGJDJRDIj+u4fD75P3VX4Y1lN9Slc= X-Received: by 2002:a05:6000:3113:b0:3c9:f8a:f257 with SMTP id ffacd0b85a97d-3c90f8af5cbmr2996345f8f.50.1756132686339; Mon, 25 Aug 2025 07:38:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCFvBJRBfcBEdo8i70/6pukUQNYn2Qrs6ZnSbppOdelrrIoC/z5rNFiWI+fX6KVi1Xqpq2ow== X-Received: by 2002:a05:6000:3113:b0:3c9:f8a:f257 with SMTP id ffacd0b85a97d-3c90f8af5cbmr2996318f8f.50.1756132685799; Mon, 25 Aug 2025 07:38:05 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76? (p200300d82f4f130042f198e5ddf83a76.dip0.t-ipconnect.de. [2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b5744e9b1sm109711045e9.11.2025.08.25.07.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 07:38:05 -0700 (PDT) Message-ID: Date: Mon, 25 Aug 2025 16:38:03 +0200 Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/35] mm/hugetlb: cleanup hugetlb_folio_init_tail_vmemmap() To: Mike Rapoport Cc: =?UTF-8?Q?Mika_Penttil=C3=A4?= , linux-kernel@vger.kernel.org, Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan References: <20250821200701.1329277-1-david@redhat.com> <20250821200701.1329277-11-david@redhat.com> <9156d191-9ec4-4422-bae9-2e8ce66f9d5e@redhat.com> <7077e09f-6ce9-43ba-8f87-47a290680141@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 25.08.25 16:32, Mike Rapoport wrote: > On Mon, Aug 25, 2025 at 02:48:58PM +0200, David Hildenbrand wrote: >> On 23.08.25 10:59, Mike Rapoport wrote: >>> On Fri, Aug 22, 2025 at 08:24:31AM +0200, David Hildenbrand wrote: >>>> On 22.08.25 06:09, Mika Penttilä wrote: >>>>> >>>>> On 8/21/25 23:06, David Hildenbrand wrote: >>>>> >>>>>> All pages were already initialized and set to PageReserved() with a >>>>>> refcount of 1 by MM init code. >>>>> >>>>> Just to be sure, how is this working with MEMBLOCK_RSRV_NOINIT, where MM is supposed not to >>>>> initialize struct pages? >>>> >>>> Excellent point, I did not know about that one. >>>> >>>> Spotting that we don't do the same for the head page made me assume that >>>> it's just a misuse of __init_single_page(). >>>> >>>> But the nasty thing is that we use memblock_reserved_mark_noinit() to only >>>> mark the tail pages ... >>> >>> And even nastier thing is that when CONFIG_DEFERRED_STRUCT_PAGE_INIT is >>> disabled struct pages are initialized regardless of >>> memblock_reserved_mark_noinit(). >>> >>> I think this patch should go in before your updates: >> >> Shouldn't we fix this in memblock code? >> >> Hacking around that in the memblock_reserved_mark_noinit() user sound wrong >> -- and nothing in the doc of memblock_reserved_mark_noinit() spells that >> behavior out. > > We can surely update the docs, but unfortunately I don't see how to avoid > hacking around it in hugetlb. > Since it's used to optimise HVO even further to the point hugetlb open > codes memmap initialization, I think it's fair that it should deal with all > possible configurations. Remind me, why can't we support memblock_reserved_mark_noinit() when CONFIG_DEFERRED_STRUCT_PAGE_INIT is disabled? -- Cheers David / dhildenb