From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7091AD3F5 for ; Mon, 4 Nov 2024 09:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730712430; cv=none; b=rTGhr9bbB3w/RvXmNJWygmR49AAzt57690pw0OX6Rhq/zPjSf6LPx0aCPA3VH1kMbiwNzjf12ad7vGI0C6mF3FpkGhahdCmoMZ+W/OdGzOSQYathcTMznwYS1r1QuJE3mUBpRBbKK3sfJYx48d2apBFLsvaIvXZfqBv9S+UhrIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730712430; c=relaxed/simple; bh=M7ueN/LQ529FLGouL/3BXVgrjx8tY87847WIrlhrom4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aj2VFHgtEfBbzXiKn31HxG805Qm38JjvCT8pZUc0x+UNw5P2Ct+3+H8tOHKRqUBYNEktXJt692iuOOTAfUJRewt46e3AzaePL602Su67KK+1MnYFWdnZYEntkEJ4advfqUffeqaWReCVwVYWrFLt811u7QrI3fAnKL1xkDsmybg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CS+/sPzX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CS+/sPzX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730712428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M7ueN/LQ529FLGouL/3BXVgrjx8tY87847WIrlhrom4=; b=CS+/sPzXh1mV9lC5ab3Yx6U4bXIdpqD8G+MfUAIwGT7krBbkM5YaTKx990ONiy6IiokdlF LMjoveda6hXsGqzhNWIoT3Tdm1X8iSJR1mAq3djw3G7HHg2AZEDVBOzygB32NJDK7KaxnN +VDlOhmoejlHzpQenYD4l16Pr6eWO+Q= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-DxMkFtd6NdCv8ZRSXzXEUg-1; Mon, 04 Nov 2024 04:27:07 -0500 X-MC-Unique: DxMkFtd6NdCv8ZRSXzXEUg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb652f40f1so19894071fa.2 for ; Mon, 04 Nov 2024 01:27:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730712425; x=1731317225; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=M7ueN/LQ529FLGouL/3BXVgrjx8tY87847WIrlhrom4=; b=R2J1MsAwhRDpvfiqq+N7Ae2FIwLcaqdpe9F3I1J/uuqSlM9TuQ1DhPSO5mrRVh0xm5 Wfr2nYl2zWDeizWHse+i6b8YHLRv9kVQmanJY5/JEFd7EG1PHEzZS5IEwOpdvcKNhWox fq2XSrRdP4zR9gD7VStwqL08fo02e3WFq9c+kCObIy0FRa63sgF3CmsQAyOluVBld+Zc HAW7CXusKGL27OAzB+iWkyrytfdy3R9Upwt8iJXY5qbINKekaWfzKu363FLFzKF4AZq4 F3ieiX5f+HMiR8+qo5ZvtAOssoPhmEylgi8rUG2GKIhVpNanBqaxuDzNX3MemZxJpXZI r3Iw== X-Gm-Message-State: AOJu0Yx8C6WIgE4rwtEOH7iMwefaYUMXZBsCrpvtYouaXRGfTzkocA05 2GUmT+A0a8j68XDwnJYu/m1XmTwJPczxYTmCzuR0RhVCb3pNNMA2o0gLekghwW0ih+BNeFP3LKn mbe1+DNb+t1T+Xke9OrGPHy/Rulg9mKLfEX6mJDHqW3ttQ1gplS2LLDJtfQ== X-Received: by 2002:a5d:5f54:0:b0:37d:373c:ed24 with SMTP id ffacd0b85a97d-381c7a3a49cmr8192689f8f.4.1730712414714; Mon, 04 Nov 2024 01:26:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHUG4i3r4RT/0mDz+U1cY7m40dZcu2ijC6eEouX1uNQBldOHTZd5hoduIq2TUsnjYO3wLrnew== X-Received: by 2002:a5d:5f54:0:b0:37d:373c:ed24 with SMTP id ffacd0b85a97d-381c7a3a49cmr8192628f8f.4.1730712414212; Mon, 04 Nov 2024 01:26:54 -0800 (PST) Received: from ?IPv6:2001:16b8:2d7f:e400:7f8:722c:bb2e:bb7f? (200116b82d7fe40007f8722cbb2ebb7f.dip.versatel-1u1.de. [2001:16b8:2d7f:e400:7f8:722c:bb2e:bb7f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7d20sm12817150f8f.7.2024.11.04.01.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 01:26:53 -0800 (PST) Message-ID: Subject: Re: [PATCH 01/13] PCI: Prepare removing devres from pci_intx() From: Philipp Stanner To: Thomas Gleixner , Damien Le Moal , Niklas Cassel , Sergey Shtylyov , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jaroslav Kysela , Takashi Iwai , Chen Ni , Mario Limonciello , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Andy Shevchenko , Mostafa Saleh , Jason Gunthorpe , Yi Liu , Christian Brauner , Ankit Agrawal , Eric Auger , Reinette Chatre , Ye Bin , Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= , Pierre-Louis Bossart , Peter Ujfalusi , Maarten Lankhorst , Kai Vehmanen , Rui Salvaterra Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sound@vger.kernel.org Date: Mon, 04 Nov 2024 10:26:51 +0100 In-Reply-To: <87cyjgwfmo.ffs@tglx> References: <20241015185124.64726-1-pstanner@redhat.com> <20241015185124.64726-2-pstanner@redhat.com> <87cyjgwfmo.ffs@tglx> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-10-31 at 14:45 +0100, Thomas Gleixner wrote: > On Tue, Oct 15 2024 at 20:51, Philipp Stanner wrote: > > +/** > > + * pci_intx - enables/disables PCI INTx for device dev, unmanaged > > version >=20 > mismatch vs. actual function name. ACK, will fix >=20 > > + * @pdev: the PCI device to operate on > > + * @enable: boolean: whether to enable or disable PCI INTx > > + * > > + * Enables/disables PCI INTx for device @pdev > > + * > > + * This function behavios identically to pci_intx(), but is never > > managed with > > + * devres. > > + */ > > +void pci_intx_unmanaged(struct pci_dev *pdev, int enable) >=20 > This is a misnomer. The function controls the INTX_DISABLE bit of a > PCI device. Something like this: >=20 > void __pci_intx_control() > { > } >=20 > static inline void pci_intx_enable(d) > { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __pci_intx_control(d, true); > } >=20 > ..... >=20 > makes it entirely clear what this is about. Well, I would agree if it were about writing a 'real' new function. But this is actually about creating a _temporary_ function which is added here and removed again in patch 12 of this same series. It wouldn't even be needed; the only reason why it exists is to make it easy for the driver maintainers concerned by patches 2-11 to review the change and understand what's going on. Hence it is "pci_intx_unmanaged()" =3D=3D "Attention, we take automatic management away from your driver" pci_intx() is then fully restored after patch 12 and it keeps its old name. Gr=C3=BC=C3=9Fe, Philipp >=20 > Hmm? >=20 > Thanks, >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tglx >=20