* [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
@ 2025-04-25 19:33 Mikko Juhani Korhonen
2025-04-28 7:40 ` Niklas Cassel
2025-04-28 7:44 ` Niklas Cassel
0 siblings, 2 replies; 4+ messages in thread
From: Mikko Juhani Korhonen @ 2025-04-25 19:33 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Niklas Cassel, linux-ide, linux-kernel
Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
6.9.0 when LPM was enabled, so disable it for this model.
Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
---
drivers/ata/libata-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 773799cfd443..5c2f26945d61 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
__ata_dev_quirks[] = {
{ "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
{ "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
+ /*
+ * This specific WD SATA-3 model has problems with LPM.
+ */
+ { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
+
/*
* This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
* log page is accessed. Ensure we never ask for this log page with
base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
2025-04-25 19:33 [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
@ 2025-04-28 7:40 ` Niklas Cassel
2025-04-29 10:34 ` Damien Le Moal
2025-04-28 7:44 ` Niklas Cassel
1 sibling, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2025-04-28 7:40 UTC (permalink / raw)
To: Mikko Juhani Korhonen; +Cc: Damien Le Moal, linux-ide, linux-kernel
On Fri, Apr 25, 2025 at 10:33:17PM +0300, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
> 6.9.0 when LPM was enabled, so disable it for this model.
>
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 773799cfd443..5c2f26945d61 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
> +
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
> * log page is accessed. Ensure we never ask for this log page with
>
> base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
> --
> 2.47.2
Hello Mikko,
I tried to apply this commit, but it fails with:
Applying: ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
Patch failed at 0001 ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
error: corrupt patch at line 10
Please use:
$ git format-patch -1
You should then get a foo.patch.
You should then be able to do (locally):
$ git checkout HEAD~
$ git am foo.patch
to verify that the commit can be applied.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
2025-04-28 7:40 ` Niklas Cassel
@ 2025-04-29 10:34 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2025-04-29 10:34 UTC (permalink / raw)
To: Niklas Cassel, Mikko Juhani Korhonen; +Cc: linux-ide, linux-kernel
On 4/28/25 16:40, Niklas Cassel wrote:
> On Fri, Apr 25, 2025 at 10:33:17PM +0300, Mikko Juhani Korhonen wrote:
>> Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
>> 6.9.0 when LPM was enabled, so disable it for this model.
>>
>> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
>> ---
>> drivers/ata/libata-core.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 773799cfd443..5c2f26945d61 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
>> __ata_dev_quirks[] = {
>> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>>
>> + /*
>> + * This specific WD SATA-3 model has problems with LPM.
>> + */
>> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
>> +
>> /*
>> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
>> * log page is accessed. Ensure we never ask for this log page with
>>
>> base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
>> --
>> 2.47.2
>
> Hello Mikko,
>
> I tried to apply this commit, but it fails with:
>
> Applying: ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
> Patch failed at 0001 ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
> error: corrupt patch at line 10
>
>
> Please use:
> $ git format-patch -1
> You should then get a foo.patch.
And please do not copy-paste that into a mailer. Use "git send-email" to send
the patch.
>
> You should then be able to do (locally):
> $ git checkout HEAD~
> $ git am foo.patch
>
> to verify that the commit can be applied.
>
>
> Kind regards,
> Niklas
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
2025-04-25 19:33 [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
2025-04-28 7:40 ` Niklas Cassel
@ 2025-04-28 7:44 ` Niklas Cassel
1 sibling, 0 replies; 4+ messages in thread
From: Niklas Cassel @ 2025-04-28 7:44 UTC (permalink / raw)
To: Mikko Juhani Korhonen; +Cc: Damien Le Moal, linux-ide, linux-kernel
On Fri, Apr 25, 2025 at 10:33:17PM +0300, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
> 6.9.0 when LPM was enabled, so disable it for this model.
>
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 773799cfd443..5c2f26945d61 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
> +
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
> * log page is accessed. Ensure we never ask for this log page with
>
> base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
> --
> 2.47.2
When submitting a v4,
please add:
Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
So that Sasha's scripts will see it and backport it to stable kernels.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-29 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 19:33 [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
2025-04-28 7:40 ` Niklas Cassel
2025-04-29 10:34 ` Damien Le Moal
2025-04-28 7:44 ` Niklas Cassel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox