Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Mikko Juhani Korhonen <mjkorhon@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	Ioannis Barkas <jnyb.de@gmail.com>,
	linux-ide@vger.kernel.org, Mario Limonciello <superm1@kernel.org>,
	Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
Date: Mon, 12 May 2025 13:20:35 +0200	[thread overview]
Message-ID: <aCHZg4tj6YwS9vph@ryzen> (raw)
In-Reply-To: <CAAZ0mTfqE+w8BBCyVSg0KKQ6fYZwKaqvh_ND8dLCANg-oMaphA@mail.gmail.com>

Hello Mikko,

On Mon, May 12, 2025 at 01:34:38PM +0300, Mikko Juhani Korhonen wrote:

(snip)

> > Ok, so the bad 6.14.5 dmesg you shared before (where you got timeouts),
> > was when using SATA ports 5,6 ?
>
> Yes, and you can see in the logs, ataX matches the motherboard's SATA
> port number.
>
>
> > So, if we really want to have a quirk which disables LPM only for ports 5-6,
> > it would probably have to be a DMI quirk, which matches the motherboard name,
> > see e.g.:
> > https://github.com/torvalds/linux/blob/v6.15-rc6/drivers/ata/ahci.c#L1120-L1145
>
> And even this would disable LPM for the case of
> sata ports 5,6 -> WDC WD5000AAKX-001CA0
> which works now?

Oh, that drive works on ports 5-6 ?

I assumed that no drive that supports LPM worked on ports 5-6.
(And that you simply reported WD20EFAX-68FB5N0 because that is
what you had plugged in on that port originally.)


So you are saying that:
WD5000AAKX-001CA0 works with LPM enabled (lpm-pol 3), on port 5-6.
but
WD20EFAX-68FB5N0 gets timeouts with LPM enabled (lpm-pol 3), on port 5-6.

That is weird indeed.


From your earlier emails you have shared hdparm output from:
WD20EFAX-68FB5N0

which showed:
	Enabled		Supported
	*		Host-initiated interface power management
			Device-initiated interface power management

i.e. that HIPM and DIPM was supported, but only HIPM was enabled.
That is a bit weird, since you are using this on 6.14.5 and saw lpm-pol 3,
which means: ATA_LPM_MED_POWER_WITH_DIPM.

So I would have expected both HIPM and DIPM to have shown enabled in that
case, see:
https://github.com/torvalds/linux/blob/v6.15-rc6/drivers/ata/libata-eh.c#L3510-L3521


I could not find the similar hdparm output for WDC WD5000AAKX-001CA0.
Could you please post that as well?


Kind regards,
Niklas

  reply	other threads:[~2025-05-12 11:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 20:36 [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Ioannis Barkas
2025-05-01 18:47 ` Damien Le Moal
2025-05-02  1:32   ` Damien Le Moal
2025-05-05  7:58     ` Mikko Juhani Korhonen
2025-05-05 15:37       ` Niklas Cassel
2025-05-05 17:09         ` Mikko Juhani Korhonen
2025-05-07  8:55           ` Damien Le Moal
2025-05-10 10:14             ` Mikko Juhani Korhonen
2025-05-10 11:59               ` Niklas Cassel
2025-05-10 18:29                 ` Ioannis Barkas
2025-05-11 17:08                 ` Mikko Juhani Korhonen
2025-05-11 18:53                   ` Niklas Cassel
2025-05-11 18:59                     ` Mikko Juhani Korhonen
2025-05-11 19:18                       ` Niklas Cassel
2025-05-11 20:40                         ` Mikko Juhani Korhonen
2025-05-12  5:37                         ` Mikko Juhani Korhonen
2025-05-12  9:25                           ` Niklas Cassel
2025-05-12 10:34                             ` Mikko Juhani Korhonen
2025-05-12 11:20                               ` Niklas Cassel [this message]
     [not found]                                 ` <CAAZ0mTeiVqZQvkWzJ8aFH4FUPCZwy5O+9hPBgDPhSgNNz+t6HA@mail.gmail.com>
2025-05-14 17:57                                   ` Niklas Cassel
2025-05-17 16:31                                     ` Mikko Juhani Korhonen
     [not found]                                     ` <CAAZ0mTdZEd6n+tDvqbqzMQS2W+3efpYOeHupYcj3rDSVeuHFBA@mail.gmail.com>
2025-05-23 14:05                                       ` Niklas Cassel
2025-06-02 11:17                                     ` Mikko Juhani Korhonen
2025-06-05 12:18                                       ` Niklas Cassel
2025-06-09 13:49                                         ` Niklas Cassel
2025-06-11 13:14                                           ` Mikko Juhani Korhonen
2025-06-11 13:33                                             ` Niklas Cassel
2025-05-07  8:59           ` Niklas Cassel
2025-05-08 19:24             ` Mario Limonciello
2025-05-07  8:59           ` Damien Le Moal
2025-05-11 18:55             ` Mikko Juhani Korhonen
  -- strict thread matches above, loose matches on Subject: below --
2025-05-05 19:38 Ioannis Barkas
2025-05-05 23:33 ` Damien Le Moal
2025-05-06 11:29 ` Mikko Juhani Korhonen
2025-04-29 16:44 Mikko Korhonen
2025-04-30  6:35 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCHZg4tj6YwS9vph@ryzen \
    --to=cassel@kernel.org \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=dlemoal@kernel.org \
    --cc=jnyb.de@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mjkorhon@gmail.com \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox