Re: [PATCH v2 0/5] ata_eh_set_lpm() cleanups

[Niklas Cassel <cassel@kernel.org>]

On Tue, May 20, 2025 at 07:36:34AM +0300, Mikko Juhani Korhonen wrote:
> to 15.5.2025 klo 16.56 Niklas Cassel (cassel@kernel.org) kirjoitti:
> >
> > Hello all,
> >
> > I was trying to understand ata_eh_set_lpm(), and decided that
> > it needed some cleanups to make the code more understandable.
> >
> > Please have a look.
> >
> >
> > Changes since v1:
> > -Squashed patches 3 and 4 as requested by Damien.
> > -Squashed patches 6 and 7 as requested by Damien.
> > -Changed WARN_ON to WARN_ON_ONCE.
> > -Changed patch 1 to remove parts of a comment that is no longer true.
> >
> >
> > Niklas Cassel (5):
> >   ata: libata-eh: Update DIPM comments to reflect reality
> >   ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE
> >   ata: libata-eh: Rename hipm and dipm variables
> >   ata: libata-eh: Rename no_dipm variable to be more clear
> >   ata: libata-eh: Keep DIPM disabled while modifying the allowed LPM
> >     states
> >
> >  drivers/ata/libata-eh.c | 39 ++++++++++++++++++++++++++-------------
> >  1 file changed, 26 insertions(+), 13 deletions(-)
> >
> > --
> > 2.49.0
> >
> 
> Hello Niklas!
> 
> just tried this patch set for the non working case of my
> sata ports 5,6 -> WDC WD20EFAX-68FB5N0
> but as was kind of expected there was not any change.

Hello Mikko,


Thank you for testing!


Yes, it was expected to not make any difference for your problem.

I'm not sure if you are able to workaround your problem by simply
using ports other than ports 5,6.

If you feel that the problem has to be addressed, then I think that
we would need to introduce a quirk for your motherboard name that
disables LPM for ports 5,6 only.


Kind regards,
Niklas