From: Niklas Cassel <cassel@kernel.org>
To: Mikko Juhani Korhonen <mjkorhon@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Ioannis Barkas <jnyb.de@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
Date: Fri, 23 May 2025 16:05:19 +0200 [thread overview]
Message-ID: <aDCAn4PVlicQXuhi@ryzen> (raw)
In-Reply-To: <CAAZ0mTdZEd6n+tDvqbqzMQS2W+3efpYOeHupYcj3rDSVeuHFBA@mail.gmail.com>
Mikko,
On Fri, May 23, 2025 at 04:27:23PM +0300, Mikko Juhani Korhonen wrote:
> > I would add some debug prints around:
> >
> > https://github.com/torvalds/linux/blob/v6.15-rc6/drivers/ata/libata-eh.c#L3512-L3520
> >
> > To
> > 1) Make sure that we actually send down the SET FEATURES command for
> > to the drive.
> >
> > 2) Check the return code (err_mask). This code looks a bit sketchy,
> > if (err_mask && err_mask != AC_ERR_DEV) {
> >
> > It seems that if err_mask == AC_ERR_DEV, the error would get silently
> > discarded...
>
>
> Hello Niklas,
> I did add debug print here and checked that at least there is no silently
> ignored errors here, err_mask is zero even for my problem case
> sata ports 5,6 -> WDC WD20EFAX-68FB5N0
> and also for some others I tested.
Thanks a lot for testing!
Kind regards,
Niklas
next prev parent reply other threads:[~2025-05-23 14:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 20:36 [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Ioannis Barkas
2025-05-01 18:47 ` Damien Le Moal
2025-05-02 1:32 ` Damien Le Moal
2025-05-05 7:58 ` Mikko Juhani Korhonen
2025-05-05 15:37 ` Niklas Cassel
2025-05-05 17:09 ` Mikko Juhani Korhonen
2025-05-07 8:55 ` Damien Le Moal
2025-05-10 10:14 ` Mikko Juhani Korhonen
2025-05-10 11:59 ` Niklas Cassel
2025-05-10 18:29 ` Ioannis Barkas
2025-05-11 17:08 ` Mikko Juhani Korhonen
2025-05-11 18:53 ` Niklas Cassel
2025-05-11 18:59 ` Mikko Juhani Korhonen
2025-05-11 19:18 ` Niklas Cassel
2025-05-11 20:40 ` Mikko Juhani Korhonen
2025-05-12 5:37 ` Mikko Juhani Korhonen
2025-05-12 9:25 ` Niklas Cassel
2025-05-12 10:34 ` Mikko Juhani Korhonen
2025-05-12 11:20 ` Niklas Cassel
[not found] ` <CAAZ0mTeiVqZQvkWzJ8aFH4FUPCZwy5O+9hPBgDPhSgNNz+t6HA@mail.gmail.com>
2025-05-14 17:57 ` Niklas Cassel
2025-05-17 16:31 ` Mikko Juhani Korhonen
[not found] ` <CAAZ0mTdZEd6n+tDvqbqzMQS2W+3efpYOeHupYcj3rDSVeuHFBA@mail.gmail.com>
2025-05-23 14:05 ` Niklas Cassel [this message]
2025-06-02 11:17 ` Mikko Juhani Korhonen
2025-06-05 12:18 ` Niklas Cassel
2025-06-09 13:49 ` Niklas Cassel
2025-06-11 13:14 ` Mikko Juhani Korhonen
2025-06-11 13:33 ` Niklas Cassel
2025-05-07 8:59 ` Niklas Cassel
2025-05-08 19:24 ` Mario Limonciello
2025-05-07 8:59 ` Damien Le Moal
2025-05-11 18:55 ` Mikko Juhani Korhonen
-- strict thread matches above, loose matches on Subject: below --
2025-05-05 19:38 Ioannis Barkas
2025-05-05 23:33 ` Damien Le Moal
2025-05-06 11:29 ` Mikko Juhani Korhonen
2025-04-29 16:44 Mikko Korhonen
2025-04-30 6:35 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDCAn4PVlicQXuhi@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jnyb.de@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mjkorhon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).