From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>,
Alexander Roman <monderasdor@gmail.com>,
linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] ahci: enhance error handling in ahci_init_one
Date: Mon, 26 May 2025 10:11:32 +0200 [thread overview]
Message-ID: <aDQiNEfh2i-XTAxs@ryzen> (raw)
In-Reply-To: <C819CAA3-3F8B-44A3-BD65-82B06378839E@kernel.org>
Hello Alexander,
On Sun, May 25, 2025 at 12:10:07AM +0200, Niklas Cassel wrote:
> >> @@ -1619,60 +1619,72 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> >> VPRINTK("ahci_init_one enter\n");
>
> There is no VPRINTK() here since a long time ago.
>
> So this must be based on some ancient kernel version.
>
> Please base your patches on:
> https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-next
Sorry, but I forgot to mention, please don't use the In-Reply-To: header
to reference older versions of your patch.
To quote Submitting Patches, it creates an 'unmanageable forest':
https://docs.kernel.org/process/submitting-patches.html#explicit-in-reply-to-headers
Kind regards,
Niklas
prev parent reply other threads:[~2025-05-26 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 22:13 [PATCH V2] ahci: enhance error handling and resource management in ahci_init_one Alexander Roman
2025-05-22 5:42 ` Damien Le Moal
2025-05-22 10:00 ` [PATCH V3] " Alexander Roman
2025-05-24 12:37 ` Damien Le Moal
2025-05-22 10:26 ` [PATCH V3] ahci: enhance error handling " Alexander Roman
2025-05-24 12:36 ` Damien Le Moal
2025-05-24 22:10 ` Niklas Cassel
2025-05-26 8:11 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDQiNEfh2i-XTAxs@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monderasdor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox