Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

[Niklas Cassel <cassel@kernel.org>]

Hello Mikko,

On Thu, Jun 05, 2025 at 02:18:16PM +0200, Niklas Cassel wrote:
> 
> Personally, I think that checking for certain port numbers, for a specific
> motherboard makes the code very ugly, and will not scale very well if some
> other motherboard has a different subset of ports where LPM does not work,
> so I would rather avoid a quirk handling port numbers.
> 
> It is unfortunate that the BIOS manufacturer has managed to mess this up,
> but since this is the first motherboard where I've heard about the problem
> of LPM only working on certain ports, even though it is a per controller
> thing, just not having good power saving for this motherboard seems fine.
> 
> I suggest that we simply add the DMI name of your motherboard to
> ahci_broken_lpm().

I just sent out a series which refactors ahci_broken_lpm():
https://lore.kernel.org/linux-ide/20250609134539.943587-3-cassel@kernel.org/T/#u

When sending your patch, please base it on top of that series.

(As without that series, it is not possible to add an entry
where there is no good BIOS version that has been released.)


Kind regards,
Niklas