linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: macio: Use non-hybrid PCI devres API
Date: Tue, 10 Jun 2025 14:31:20 +0200	[thread overview]
Message-ID: <aEglmHpvqZhbG_AX@ryzen> (raw)
In-Reply-To: <20250604113423.138595-2-phasta@kernel.org>

Hello Philipp,

On Wed, Jun 04, 2025 at 01:34:24PM +0200, Philipp Stanner wrote:
> macio enables its PCI device with pcim_enable_device(). This,
> implicitly, switches the function pci_request_regions() into managed
> mode, where it becomes a devres function.
> 
> The PCI subsystem wants to remove this hybrid nature from its
> interfaces. To do so, users of the aforementioned combination of
> functions must be ported to non-hybrid functions.
> 
> Replace the call to sometimes-managed pci_request_regions() with one to
> the always-managed pcim_request_all_regions().
> 
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---
> Hi,
> seems I forgot sending this patch out a while ago. Mea culpa.
> 
> PCI has currently chained the changes mentioned above queued up for

chained?


> Linus, so it's probably a good idea to get this into macio relatively
> soonish. Otherwise the driver would likely fail to reload in v6.16,
> because the device's PCI regions remain blocked.

I can queue this up for 6.16, but then I think you need to rewrite the
commit message to motivate why it is a fix (i.e. why it deserves to go
in to 6.16-rc2).

Or, I can just queue it up for 6.17.

What do you prefer?


Kind regards,
Niklas

  parent reply	other threads:[~2025-06-10 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 11:34 [PATCH] ata: macio: Use non-hybrid PCI devres API Philipp Stanner
2025-06-06  1:17 ` Damien Le Moal
2025-06-10 12:31 ` Niklas Cassel [this message]
2025-06-10 13:19   ` Philipp Stanner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEglmHpvqZhbG_AX@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phasta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).