From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 3/6] ata: Fix SATA_MOBILE_LPM_POLICY description in Kconfig
Date: Fri, 27 Jun 2025 12:54:30 +0200 [thread overview]
Message-ID: <aF54ZpjsKP6Efezi@ryzen> (raw)
In-Reply-To: <20250627075207.23969-4-dlemoal@kernel.org>
On Fri, Jun 27, 2025 at 04:52:04PM +0900, Damien Le Moal wrote:
> Improve the description of the possible default SATA link power
> management policies and add the missing description for policy 5.
> No functional changes.
>
> Fixes: a5ec5a7bfd1f ("ata: ahci: Support state with min power but Partial low power state")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/ata/Kconfig | 36 ++++++++++++++++++++++++++----------
> 1 file changed, 26 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index e00536b49552..1d53d7b568bd 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -117,23 +117,39 @@ config SATA_AHCI
>
> config SATA_MOBILE_LPM_POLICY
> int "Default SATA Link Power Management policy"
> - range 0 4
> + range 0 5
> default 3
> depends on SATA_AHCI
> help
> Select the Default SATA Link Power Management (LPM) policy to use
> for chipsets / "South Bridges" supporting low-power modes. Such
> chipsets are ubiquitous across laptops, desktops and servers.
> -
> - The value set has the following meanings:
> + Each policy combines power saving states and features:
> + - Partial: The Phy logic is powered but is in a reduced power
> + state. The exit latency from this state is no longer than
> + 10us).
> + - Slumber: The Phy logic is powered but is in an even lower power
> + state. The exit latency from this state is potentially
> + longer, but no longer than 10ms.
> + - DevSleep: The Phy logic may be powered down. The exit latency from
> + this state is no longer than 20 ms, unless otherwise
> + specified by DETO in the device Identify Device Data log.
> + - HIPM: Host Initiated Power Management (host automatic transisitons
s/transisitons/transitions/
Perhaps:
s/automatic/automatically/
> + to partial and slumber).
> + - DIPM: Device Initiated Power Management (device automatic
Perhaps:
s/automatic/automatically/
> + transitions to partial and slumber).
With that:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-06-27 10:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 7:52 [PATCH v2 0/6] Various cleanups Damien Le Moal
2025-06-27 7:52 ` [PATCH v2 1/6] ata: libata: Remove ATA_DFLAG_ZAC device flag Damien Le Moal
2025-06-27 10:53 ` Niklas Cassel
2025-06-27 7:52 ` [PATCH v2 2/6] ata: libata-scsi: Cleanup ata_scsi_offline_dev() Damien Le Moal
2025-06-27 10:53 ` Niklas Cassel
2025-06-27 7:52 ` [PATCH v2 3/6] ata: Fix SATA_MOBILE_LPM_POLICY description in Kconfig Damien Le Moal
2025-06-27 10:54 ` Niklas Cassel [this message]
2025-06-27 7:52 ` [PATCH v2 4/6] ata: libata: Improve LPM policies description Damien Le Moal
2025-06-27 9:08 ` Hannes Reinecke
2025-06-27 10:54 ` Niklas Cassel
2025-06-27 7:52 ` [PATCH v2 5/6] ata: ahci: Clarify mobile_lpm_policy description Damien Le Moal
2025-06-27 10:55 ` Niklas Cassel
2025-06-27 7:52 ` [PATCH v2 6/6] ata: libata-eh: Move and rename ata_eh_set_lpm() Damien Le Moal
2025-06-27 10:55 ` Niklas Cassel
2025-06-30 3:58 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF54ZpjsKP6Efezi@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox