From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 01/10] ata: libata-core: Introduce ata_dev_config_lpm()
Date: Tue, 1 Jul 2025 12:41:31 +0200 [thread overview]
Message-ID: <aGO7WxLsT6zCZRoq@ryzen> (raw)
In-Reply-To: <20250701001408.330364-2-dlemoal@kernel.org>
On Tue, Jul 01, 2025 at 09:13:59AM +0900, Damien Le Moal wrote:
(snip)
> Though DIPM is disabled on
> a drive by default thanks to the "Software Settings Preservation
> feature", DIPM may have been enabled by the system firmware when using
> the LPM policy "Keep FW settings" (ATA_LPM_UNKNOWN).
I see that you improved the commit message, but I actually meant that
maybe we should mention this in the comment above the disabling of DIPM
in ata_dev_config_lpm().
(Since someone just reading AHCI 1.3.1, "8.3.1.1 Device Initiated" will
probably read this sentence:
By default, a device that supports initiating interface power management
states has the capability disabled.
You basically need to read ACS-6 or SATA 3.5a to find out about
"Software Settings Preservation feature" and that DIPM can actually
stay enabled across a COMRESET.)
Regardless:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-07-01 10:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 0:13 [PATCH v2 00/10] Improve link power management Damien Le Moal
2025-07-01 0:13 ` [PATCH v2 01/10] ata: libata-core: Introduce ata_dev_config_lpm() Damien Le Moal
2025-07-01 10:41 ` Niklas Cassel [this message]
2025-07-01 0:14 ` [PATCH v2 02/10] ata: libata-core: Move device LPM quirk settings to ata_dev_config_lpm() Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 03/10] ata: libata-core: Advertize device support for DIPM and HIPM features Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 04/10] ata: libata-eh: Avoid unnecessary resets when revalidating devices Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 05/10] ata: libata-sata: Disallow changing LPM state if not supported Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 06/10] ata: ahci: Disable DIPM if host lacks support Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 07/10] ata: ahci: Disallow LPM policy control for external ports Damien Le Moal
2025-07-01 9:43 ` Niklas Cassel
2025-07-01 0:14 ` [PATCH v2 08/10] ata: ahci: Disallow LPM policy control if not supported Damien Le Moal
2025-07-01 9:44 ` Niklas Cassel
2025-07-01 0:14 ` [PATCH v2 09/10] ata: libata-core: Reduce the number of messages signaling broken LPM Damien Le Moal
2025-07-01 0:14 ` [PATCH v2 10/10] ata: libata_eh: Add debug messages to ata_eh_link_set_lpm() Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGO7WxLsT6zCZRoq@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).