Re: [PATCH] ata: libata-core: relax checks in ata_read_log_directory()

[Niklas Cassel <cassel@kernel.org>]

On Thu, Oct 09, 2025 at 07:46:00PM +0900, Damien Le Moal wrote:
> Commit 6d4405b16d37 ("ata: libata-core: Cache the general purpose log
> directory") introduced caching of a device general purpose log directory
> to avoid repeated access to this log page during device scan. This
> change also added a check on this log page to verify that the log page
> version is 0x0001 as mandated by the ACS specifications.
> 
> And it turns out that some devices do not bother reporting this version,
> instead reporting a version 0, resulting in error messages such as:
> 
> ata6.00: Invalid log directory version 0x0000
> 
> and to the device being marked as not supporting the general purpose log
> directory log page.
> 
> Since before commit 6d4405b16d37 the log page version check did not
> exist and things were still working correctly for these devices, relax
> ata_read_log_directory() version check and only warn about the invalid
> log page version number without disabling access to the log directory
> page.
> 
> Fixes: 6d4405b16d37 ("ata: libata-core: Cache the general purpose log directory")
> Cc: stable@vger.kernel.org
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220635
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

Looks good, will queue up after -rc1.


Kind regards,
Niklas