[PATCH] fix PCMCIA Iomega Clik!

[PATCH] fix PCMCIA Iomega Clik!

[René Rebe]

Add PCMCIA Iomega Clik! ID to pata_pcmcia.

-- Signed-off-by: René Rebe <rene@exactco.de>

--- a/drivers/ata/pata_pcmcia.c	2025-02-27 18:51:20.641993816 +0100
+++ b/drivers/ata/pata_pcmcia.c	2025-02-27 18:56:22.022992807 +0100
@@ -362,6 +362,7 @@
 	PCMCIA_DEVICE_PROD_ID12("STI", "Flash 5.0", 0xbf2df18d, 0x8cb57a0e),
 	PCMCIA_MFC_DEVICE_PROD_ID12(1, "SanDisk", "ConnectPlus", 0x7a954bd9, 0x74be00c6),
 	PCMCIA_DEVICE_PROD_ID2("Flash Card", 0x5a362506),
+	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888D7B73),
 	PCMCIA_DEVICE_NULL,
 };
 
-- 
  René Rebe, ExactCODE GmbH, Berlin, Germany
  https://exactco.de | https://t2linux.com | https://rene.rebe.de

Re: [PATCH] fix PCMCIA Iomega Clik!

[Niklas Cassel]

Hello René,

On Mon, Nov 17, 2025 at 01:43:21PM +0100, René Rebe wrote:

Please change the subject to include: "ata: pata_pcmcia: " prefix.

I.e. something like:

ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

Looking at:
https://en.wikipedia.org/wiki/PocketZip

It seems like this device was renamed to PocketZip.

So perhaps:
ata: pata_pcmcia: Add Iomega PocketZip Drive


> Add PCMCIA Iomega Clik! ID to pata_pcmcia.

Perhaps:
Add Iomega PocketZip Drive ID to pata_pcmcia.


> 
> -- Signed-off-by: René Rebe <rene@exactco.de>

There should be no "-- " before the Signed-off-by, see:
https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1


> 
> --- a/drivers/ata/pata_pcmcia.c	2025-02-27 18:51:20.641993816 +0100
> +++ b/drivers/ata/pata_pcmcia.c	2025-02-27 18:56:22.022992807 +0100
> @@ -362,6 +362,7 @@
>  	PCMCIA_DEVICE_PROD_ID12("STI", "Flash 5.0", 0xbf2df18d, 0x8cb57a0e),
>  	PCMCIA_MFC_DEVICE_PROD_ID12(1, "SanDisk", "ConnectPlus", 0x7a954bd9, 0x74be00c6),
>  	PCMCIA_DEVICE_PROD_ID2("Flash Card", 0x5a362506),
> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888D7B73),

I think this should be something like:
PCMCIA_DEVICE_PROD_ID2("Iomega PocketZip Drive", 0x888D7B73),

Also, make sure that you add this entry at the correct place, i.e. in
alphabetical order (Iomega, before IBM), please also make the hex ID
string in lower case letters to match the existing entries.


Kind regards,
Niklas

Re: [PATCH] fix PCMCIA Iomega Clik!

[René Rebe]

On Tue, 18 Nov 2025 15:56:07 +0100, Niklas Cassel <cassel@kernel.org> wrote:

> Hello René,
> 
> On Mon, Nov 17, 2025 at 01:43:21PM +0100, René Rebe wrote:
> 
> Please change the subject to include: "ata: pata_pcmcia: " prefix.
> 
> I.e. something like:
> 
> ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

sure, will resend.

> Looking at:
> https://en.wikipedia.org/wiki/PocketZip
> 
> It seems like this device was renamed to PocketZip.

My devices have all stickers with Clik! I don't have a PocketZip to
test.

> So perhaps:
> ata: pata_pcmcia: Add Iomega PocketZip Drive
> 
> 
> > Add PCMCIA Iomega Clik! ID to pata_pcmcia.
> 
> Perhaps:
> Add Iomega PocketZip Drive ID to pata_pcmcia.
> 
> 
> > 
> > -- Signed-off-by: René Rebe <rene@exactco.de>
> 
> There should be no "-- " before the Signed-off-by, see:
> https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Yes, of course.

> > 
> > --- a/drivers/ata/pata_pcmcia.c	2025-02-27 18:51:20.641993816 +0100
> > +++ b/drivers/ata/pata_pcmcia.c	2025-02-27 18:56:22.022992807 +0100
> > @@ -362,6 +362,7 @@
> >  	PCMCIA_DEVICE_PROD_ID12("STI", "Flash 5.0", 0xbf2df18d, 0x8cb57a0e),
> >  	PCMCIA_MFC_DEVICE_PROD_ID12(1, "SanDisk", "ConnectPlus", 0x7a954bd9, 0x74be00c6),
> >  	PCMCIA_DEVICE_PROD_ID2("Flash Card", 0x5a362506),
> > +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888D7B73),
> 
> I think this should be something like:
> PCMCIA_DEVICE_PROD_ID2("Iomega PocketZip Drive", 0x888D7B73),
> 
> Also, make sure that you add this entry at the correct place, i.e. in
> alphabetical order (Iomega, before IBM), please also make the hex ID
> string in lower case letters to match the existing entries.

Did not notice the list was fully ordered, the hex probabbly pasted
from some pcmcia tools output. But happy to reformat for v2 ;-)

Thanks,
	René

-- 
René Rebe, ExactCODE GmbH, Berlin, Germany
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe

Re: [PATCH] fix PCMCIA Iomega Clik!

[Niklas Cassel]

On Tue, Nov 18, 2025 at 04:13:05PM +0100, René Rebe wrote:
> On Tue, 18 Nov 2025 15:56:07 +0100, Niklas Cassel <cassel@kernel.org> wrote:
> 
> > Hello René,
> > 
> > On Mon, Nov 17, 2025 at 01:43:21PM +0100, René Rebe wrote:
> > 
> > Please change the subject to include: "ata: pata_pcmcia: " prefix.
> > 
> > I.e. something like:
> > 
> > ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter
> 
> sure, will resend.
> 
> > Looking at:
> > https://en.wikipedia.org/wiki/PocketZip
> > 
> > It seems like this device was renamed to PocketZip.
> 
> My devices have all stickers with Clik! I don't have a PocketZip to
> test.

Since it was a simple rebranding, I assumed that Iomega PocketZip and
Iomega Clik! had the same device ID, but if we can't find out for sure
if they actually have the same device ID, then I guess it is better to
keep the Iomega Clik name.


Kind regards,
Niklas