Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[Niklas Cassel <cassel@kernel.org>]

On Tue, Nov 18, 2025 at 09:20:17PM +0100, René Rebe wrote:
> IOn 18. Nov 2025, at 21:08, Niklas Cassel <cassel@kernel.org> wrote:
> > 
> > On Tue, Nov 18, 2025 at 05:46:54PM +0100, René Rebe wrote:
> >> Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.
> >> 
> >> Signed-off-by: René Rebe <rene@exactco.de>
> >> ---
> >> v2: style and sorted
> >> ---
> >> drivers/ata/pata_pcmcia.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> >> index cf3810933a27..caefcd8c4b3c 100644
> >> --- a/drivers/ata/pata_pcmcia.c
> >> +++ b/drivers/ata/pata_pcmcia.c
> >> @@ -344,6 +344,7 @@ static const struct pcmcia_device_id pcmcia_devices[] = {
> >> 	PCMCIA_DEVICE_PROD_ID2("NinjaATA-", 0xebe0bd79),
> >> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "CD-ROM", 0x281f1c5d, 0x66536591),
> >> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "PnPIDE", 0x281f1c5d, 0x0c694728),
> >> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
> > 
> > Don't we want Iomega somewhere in the name here?
> 
> 
> IIRC this string came out of some pcmcia tool. I thought it came out of the device.
> Is it not used for matching or should match what comes out of the device IDENTIFY
> or so command?

Looking at drivers/pcmcia/ds.c, you are right,
the string is used for matching.

So we are stuck with this quite generic name :)


Kind regards,
Niklas