[PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[René Rebe]

Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.

Signed-off-by: René Rebe <rene@exactco.de>
---
v2: style and sorted
---
 drivers/ata/pata_pcmcia.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
index cf3810933a27..caefcd8c4b3c 100644
--- a/drivers/ata/pata_pcmcia.c
+++ b/drivers/ata/pata_pcmcia.c
@@ -344,6 +344,7 @@ static const struct pcmcia_device_id pcmcia_devices[] = {
 	PCMCIA_DEVICE_PROD_ID2("NinjaATA-", 0xebe0bd79),
 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "CD-ROM", 0x281f1c5d, 0x66536591),
 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "PnPIDE", 0x281f1c5d, 0x0c694728),
+	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
 	PCMCIA_DEVICE_PROD_ID12("SHUTTLE TECHNOLOGY LTD.", "PCCARD-IDE/ATAPI Adapter", 0x4a3f0ba0, 0x322560e1),
 	PCMCIA_DEVICE_PROD_ID12("SEAGATE", "ST1", 0x87c1b330, 0xe1f30883),
 	PCMCIA_DEVICE_PROD_ID12("SAMSUNG", "04/05/06", 0x43d74cb4, 0x6a22777d),
-- 
2.46.0

-- 
René Rebe, ExactCODE GmbH, Berlin, Germany
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[Niklas Cassel]

On Tue, Nov 18, 2025 at 05:46:54PM +0100, René Rebe wrote:
> Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.
> 
> Signed-off-by: René Rebe <rene@exactco.de>
> ---
> v2: style and sorted
> ---
>  drivers/ata/pata_pcmcia.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> index cf3810933a27..caefcd8c4b3c 100644
> --- a/drivers/ata/pata_pcmcia.c
> +++ b/drivers/ata/pata_pcmcia.c
> @@ -344,6 +344,7 @@ static const struct pcmcia_device_id pcmcia_devices[] = {
>  	PCMCIA_DEVICE_PROD_ID2("NinjaATA-", 0xebe0bd79),
>  	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "CD-ROM", 0x281f1c5d, 0x66536591),
>  	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "PnPIDE", 0x281f1c5d, 0x0c694728),
> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),

Don't we want Iomega somewhere in the name here?


Kind regards,
Niklas

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[René Rebe]

IOn 18. Nov 2025, at 21:08, Niklas Cassel <cassel@kernel.org> wrote:
> 
> On Tue, Nov 18, 2025 at 05:46:54PM +0100, René Rebe wrote:
>> Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.
>> 
>> Signed-off-by: René Rebe <rene@exactco.de>
>> ---
>> v2: style and sorted
>> ---
>> drivers/ata/pata_pcmcia.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
>> index cf3810933a27..caefcd8c4b3c 100644
>> --- a/drivers/ata/pata_pcmcia.c
>> +++ b/drivers/ata/pata_pcmcia.c
>> @@ -344,6 +344,7 @@ static const struct pcmcia_device_id pcmcia_devices[] = {
>> 	PCMCIA_DEVICE_PROD_ID2("NinjaATA-", 0xebe0bd79),
>> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "CD-ROM", 0x281f1c5d, 0x66536591),
>> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "PnPIDE", 0x281f1c5d, 0x0c694728),
>> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
> 
> Don't we want Iomega somewhere in the name here?


IIRC this string came out of some pcmcia tool. I thought it came out of the device.
Is it not used for matching or should match what comes out of the device IDENTIFY
or so command?

	René

-- 
https://exactco.de - https://t2linux.com - https://rene.rebe.de

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[Niklas Cassel]

On Tue, Nov 18, 2025 at 09:20:17PM +0100, René Rebe wrote:
> IOn 18. Nov 2025, at 21:08, Niklas Cassel <cassel@kernel.org> wrote:
> > 
> > On Tue, Nov 18, 2025 at 05:46:54PM +0100, René Rebe wrote:
> >> Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.
> >> 
> >> Signed-off-by: René Rebe <rene@exactco.de>
> >> ---
> >> v2: style and sorted
> >> ---
> >> drivers/ata/pata_pcmcia.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> >> index cf3810933a27..caefcd8c4b3c 100644
> >> --- a/drivers/ata/pata_pcmcia.c
> >> +++ b/drivers/ata/pata_pcmcia.c
> >> @@ -344,6 +344,7 @@ static const struct pcmcia_device_id pcmcia_devices[] = {
> >> 	PCMCIA_DEVICE_PROD_ID2("NinjaATA-", 0xebe0bd79),
> >> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "CD-ROM", 0x281f1c5d, 0x66536591),
> >> 	PCMCIA_DEVICE_PROD_ID12("PCMCIA", "PnPIDE", 0x281f1c5d, 0x0c694728),
> >> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
> > 
> > Don't we want Iomega somewhere in the name here?
> 
> 
> IIRC this string came out of some pcmcia tool. I thought it came out of the device.
> Is it not used for matching or should match what comes out of the device IDENTIFY
> or so command?

Looking at drivers/pcmcia/ds.c, you are right,
the string is used for matching.

So we are stuck with this quite generic name :)


Kind regards,
Niklas

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[Niklas Cassel]

On Tue, 18 Nov 2025 17:46:54 +0100, René Rebe wrote:
> Add Iomega Clik! "PCMCIA ATA/ATAPI Adapter" ID to pata_pcmcia.
> 
> 

Applied to libata/linux.git (for-6.19), thanks!

[1/1] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter
      https://git.kernel.org/libata/linux/c/1d779fa9

Kind regards,
Niklas

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[Robin H. Johnson]

On Tue, Nov 18, 2025 at 09:56:39PM +0100, Niklas Cassel wrote:
> > >> +	PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
> > > Don't we want Iomega somewhere in the name here?
> > IIRC this string came out of some pcmcia tool. I thought it came out of the device.
> > Is it not used for matching or should match what comes out of the device IDENTIFY
> > or so command?
> 
> Looking at drivers/pcmcia/ds.c, you are right,
> the string is used for matching.
> 
> So we are stuck with this quite generic name :)
Generic name for the matching - but what about adding a comment that
describes where the ID & String come from as "Iomega Clik!"?

-- 
Robin Hugh Johnson (they/he)
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

Re: [PATCH V2] ata: pata_pcmcia: Add Iomega Clik! PCMCIA ATA/ATAPI Adapter

[René Rebe]

On 14. Dec 2025, at 23:59, Robin H. Johnson <robbat2@gentoo.org> wrote:
> 
> On Tue, Nov 18, 2025 at 09:56:39PM +0100, Niklas Cassel wrote:
>>>>> + PCMCIA_DEVICE_PROD_ID2("PCMCIA ATA/ATAPI Adapter", 0x888d7b73),
>>>> Don't we want Iomega somewhere in the name here?
>>> IIRC this string came out of some pcmcia tool. I thought it came out of the device.
>>> Is it not used for matching or should match what comes out of the device IDENTIFY
>>> or so command?
>> 
>> Looking at drivers/pcmcia/ds.c, you are right,
>> the string is used for matching.
>> 
>> So we are stuck with this quite generic name :)
> Generic name for the matching - but what about adding a comment that
> describes where the ID & String come from as "Iomega Clik!"?

Well the other entries also don’t have comments and in case of there is
git blame anyway.

	René

> -- 
> Robin Hugh Johnson (they/he)
> Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
> E-Mail   : robbat2@gentoo.org
> GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
> GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

-- 
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe