From: Niklas Cassel <cassel@kernel.org>
To: Yihang Li <liyihang9@h-partners.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-core: Disable LPM on Silicon Motion MD619HXCLDE3TC
Date: Tue, 25 Nov 2025 13:27:11 +0100 [thread overview]
Message-ID: <aSWgnwVzGDAqPf0i@ryzen> (raw)
In-Reply-To: <8850d82e-6818-b67f-9acb-cdfe78b7cedd@h-partners.com>
Hello Yihang Li,
On Tue, Nov 25, 2025 at 07:31:36PM +0800, Yihang Li wrote:
> Hi Niklas,
>
> On 2025/11/25 0:34, Niklas Cassel wrote:
> > According to a user report, the Silicon Motion MD619HXCLDE3TC SSD has
> > problems with LPM.
> >
> > Reported-by: Yihang Li <liyihang9@h-partners.com>
> > Closes: https://lore.kernel.org/linux-ide/20251121073502.3388239-1-liyihang9@h-partners.com/
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> > ---
> > Hello Yihang Li,
> >
> > Please test this patch.
>
> I found that the same issue also exists on another model of drive.
> The information is as follows:
>
> # lsblk -o MODEL /dev/sda
> MODEL
> MD619GXCLDE3TC
>
> # lsblk -o REV /dev/sda
> REV
> TCV35D
>
> At the same time, while testing this patch, I found that the issue was not solved.
> Therefore, I printed out the model_num and model_rev of MD619HXCLDE3TC SSD and discovered that
> the actual model_rev should be "TCVAID" instead of "ID." However, the information obtained using
> the `lsblk -o REV /dev/sdX` command showed "ID," and I am not sure why this is the case.
>
> In any case, I suggest that the final modification should look like this, and after testing,
> this modification has solved my problem.
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index f48fb63d7e85..b721a8db11c4 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4216,6 +4216,10 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> /* Apacer models with LPM issues */
> { "Apacer AS340*", NULL, ATA_QUIRK_NOLPM },
>
> + /* Silicon Motion models with LPM issues */
> + { "MD619HXCLDE3TC", "TCVAID", ATA_QUIRK_NOLPM },
> + { "MD619GXCLDE3TC", "TCV35D", ATA_QUIRK_NOLPM },
> +
Ok, really nice that we have a patch that fixes your problem.
However, like I wrote in the comment section:
Before we apply this patch, it would be nice if you could try another SSD,
that supports LPM (HIPM and DIPM) with your AHCI controller:
Huawei Technologies Co., Ltd. HiSilicon AHCI HBA [19e5:a235] (rev 30)
Note: You can see if your drive supports HIPM and DIPM from the
ata_dev_print_features() print to dmesg during boot, e.g.:
ata6.00: Features: Trust Dev-Sleep HIPM DIPM NCQ-sndrcv NCQ-prio
Just so we can verify that it is the MD619HXCLDE3TC SSD that is not
handling LPM correctly, and that it is not the AHCI HBA that is at fault.
E.g. there have been some weird bugs with this AHCI controller before,
see e.g. 234e6d2c18f5 ("ata: ahci: Disable SXS for Hisilicon Kunpeng920").
Do you have any other drive, other than MD619HXCLDE3TC and MD619GXCLDE3TC,
which supports LPM, and you can see that the drive works as intended,
with LPM enabled, so we can be certain that it is not the HBA that has
broken LPM support?
Kind regards,
Niklas
next prev parent reply other threads:[~2025-11-25 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:34 [PATCH] ata: libata-core: Disable LPM on Silicon Motion MD619HXCLDE3TC Niklas Cassel
2025-11-25 11:31 ` Yihang Li
2025-11-25 12:27 ` Niklas Cassel [this message]
2025-11-26 8:48 ` Yihang Li
2025-11-26 12:05 ` Niklas Cassel
2025-11-28 2:54 ` Yihang Li
2025-11-28 6:01 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSWgnwVzGDAqPf0i@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=liyihang9@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox