public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, Igor Pylypiv <ipylypiv@google.com>,
	Xingui Yang <yangxingui@huawei.com>,
	John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v3 0/2] Prevent non-NCQ command starvation
Date: Wed, 31 Dec 2025 11:04:49 +0100	[thread overview]
Message-ID: <aVT1QdEZq09kAjS-@ryzen> (raw)
In-Reply-To: <20251220002140.148854-1-dlemoal@kernel.org>

On Sat, Dec 20, 2025 at 09:21:38AM +0900, Damien Le Moal wrote:
> This small patch series addresses potential command starvation issues
> with non-NCQ passthrough commands issued to a device accessed through

Here and everywhere else:
s/non-NCQ passthrough commands/non-NCQ commands/

The problem is really not related to passthrough commands,
but rather the mix between NCQ and non-NCQ commands.

E.g. you can perform a ioctl with the REQ_OP_DISCARD command,
for most ATA devices this is a SCSI WRITE SAME 16 CMD, which gets
translated to either a NCQ or non-NCQ command depending on if the
device supports NCQ encapsulated Data Set Management (DSM) commands,
and specifically if the device has the QUEUED DATA SET MANAGEMENT
SUPPORTS TRIM bit set or not, which is not a given.

TL;DR: the starvation problem is not directly tied to non-NCQ
passthrough commands, but any command, even commands that goes via
the block layer, that happens to be translated to a non-NCQ command.


Kind regards,
Niklas

  parent reply	other threads:[~2025-12-31 10:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20  0:21 [PATCH v3 0/2] Prevent non-NCQ command starvation Damien Le Moal
2025-12-20  0:21 ` [PATCH v3 1/2] ata: libata-scsi: refactor ata_scsi_translate() Damien Le Moal
2025-12-22 21:19   ` Igor Pylypiv
2025-12-30 13:40   ` Niklas Cassel
2025-12-20  0:21 ` [PATCH v3 2/2] ata: libata-scsi: avoid passthrough command starvation Damien Le Moal
2025-12-22 21:28   ` Igor Pylypiv
2025-12-28  2:25     ` Damien Le Moal
2025-12-23 11:17   ` yangxingui
2025-12-31 11:17   ` Niklas Cassel
2026-01-02  0:47     ` Damien Le Moal
2026-01-02 10:24       ` Niklas Cassel
2026-01-02 11:00         ` Damien Le Moal
2025-12-31 11:39   ` Niklas Cassel
2026-01-02  1:10     ` Damien Le Moal
2026-01-02  9:46       ` Niklas Cassel
2026-01-02 11:01         ` Damien Le Moal
2025-12-31 10:04 ` Niklas Cassel [this message]
2026-01-02  1:14   ` [PATCH v3 0/2] Prevent non-NCQ " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVT1QdEZq09kAjS-@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=ipylypiv@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox