[PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI

[PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI

[Niklas Cassel]

Commit b1f5af54f1f5 ("ata: libata-core: Advertize device support for DIPM
and HIPM features") added prints if the device supports DIPM and HIPM,
however, it forgot to update the same print for ATAPI devices.

Before changes:
ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133

After changes:
ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133 HIPM DIPM

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/libata-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b96105481784..20d539730553 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3143,11 +3143,13 @@ int ata_dev_configure(struct ata_device *dev)
 		/* print device info to dmesg */
 		if (print_info)
 			ata_dev_info(dev,
-				     "ATAPI: %s, %s, max %s%s%s%s\n",
+				     "ATAPI: %s, %s, max %s%s%s%s%s%s\n",
 				     modelbuf, fwrevbuf,
 				     ata_mode_string(xfer_mask),
 				     cdb_intr_string, atapi_an_string,
-				     dma_dir_string);
+				     dma_dir_string,
+				     ata_id_has_hipm(dev->id) ? " HIPM" : "",
+				     ata_id_has_dipm(dev->id) ? " DIPM" : "");
 	}
 
 	/* determine max_sectors */
-- 
2.52.0

Re: [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI

[Niklas Cassel]

On Thu, Jan 08, 2026 at 03:12:34PM +0100, Niklas Cassel wrote:
> Commit b1f5af54f1f5 ("ata: libata-core: Advertize device support for DIPM
> and HIPM features") added prints if the device supports DIPM and HIPM,
> however, it forgot to update the same print for ATAPI devices.
> 
> Before changes:
> ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133
> 
> After changes:
> ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133 HIPM DIPM
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Don't merge this.
I think I have a nicer way.


Kind regards,
Niklas

> ---
>  drivers/ata/libata-core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b96105481784..20d539730553 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3143,11 +3143,13 @@ int ata_dev_configure(struct ata_device *dev)
>  		/* print device info to dmesg */
>  		if (print_info)
>  			ata_dev_info(dev,
> -				     "ATAPI: %s, %s, max %s%s%s%s\n",
> +				     "ATAPI: %s, %s, max %s%s%s%s%s%s\n",
>  				     modelbuf, fwrevbuf,
>  				     ata_mode_string(xfer_mask),
>  				     cdb_intr_string, atapi_an_string,
> -				     dma_dir_string);
> +				     dma_dir_string,
> +				     ata_id_has_hipm(dev->id) ? " HIPM" : "",
> +				     ata_id_has_dipm(dev->id) ? " DIPM" : "");
>  	}
>  
>  	/* determine max_sectors */
> -- 
> 2.52.0
> 

Re: [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI

[Damien Le Moal]

On 1/8/26 15:48, Niklas Cassel wrote:
> On Thu, Jan 08, 2026 at 03:12:34PM +0100, Niklas Cassel wrote:
>> Commit b1f5af54f1f5 ("ata: libata-core: Advertize device support for DIPM
>> and HIPM features") added prints if the device supports DIPM and HIPM,
>> however, it forgot to update the same print for ATAPI devices.
>>
>> Before changes:
>> ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133
>>
>> After changes:
>> ata1.00: ATAPI: Slimtype DVD A  DU8AESH, 6C2M, max UDMA/133 HIPM DIPM
>>
>> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> 
> Don't merge this.
> I think I have a nicer way.

Yeah. Adding a different "Features" message like we have for ATA and ZAC devices
would be better.

-- 
Damien Le Moal
Western Digital Research