From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, Igor Pylypiv <ipylypiv@google.com>,
Xingui Yang <yangxingui@huawei.com>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v4 2/2] ata: libata-scsi: avoid Non-NCQ command starvation
Date: Fri, 2 Jan 2026 10:48:48 +0100 [thread overview]
Message-ID: <aVeUgIk9pJzUDu5A@ryzen> (raw)
In-Reply-To: <20260102013533.1131768-3-dlemoal@kernel.org>
On Fri, Jan 02, 2026 at 10:35:33AM +0900, Damien Le Moal wrote:
> @@ -1776,9 +1864,20 @@ static int ata_scsi_translate(struct ata_device *dev, struct scsi_cmnd *cmd,
> if (xlat_func(qc))
> goto done;
>
> + /*
> + * Check if the qc must be deferred. If yes, do not report the deferral
> + * for the qc that we retained for processing using the port deferred
> + * qc work by returning 0 without issuing the qc. This signals to the
> + * SCSI layer that we * accepted the command and do not need a requeue
s/we */we/ ?
prev parent reply other threads:[~2026-01-02 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 1:35 [PATCH v4 0/2] Prevent non-NCQ command starvation Damien Le Moal
2026-01-02 1:35 ` [PATCH v4 1/2] ata: libata-scsi: refactor ata_scsi_translate() Damien Le Moal
2026-01-02 1:35 ` [PATCH v4 2/2] ata: libata-scsi: avoid Non-NCQ command starvation Damien Le Moal
2026-01-02 9:48 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVeUgIk9pJzUDu5A@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox