From: Niklas Cassel <cassel@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
Date: Fri, 20 Feb 2026 14:27:28 +0100 [thread overview]
Message-ID: <aZhhO5lMa0p41_VR@ryzen> (raw)
In-Reply-To: <20260220104208.2326568-1-andriy.shevchenko@linux.intel.com>
On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> As noticed in the discussion [1] the Baikal SoC and platforms
> are not going to be finalized, hence remove stale code.
>
> Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ata/Kconfig | 1 -
> drivers/ata/ahci_dwc.c | 54 ------------------------------------------
> 2 files changed, 55 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 2349bca136e0..fff305ec1e78 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -194,7 +194,6 @@ config AHCI_DM816
> config AHCI_DWC
> tristate "Synopsys DWC AHCI SATA support"
> select SATA_HOST
> - select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
> help
> This option enables support for the Synopsys DWC AHCI SATA
> controller implementation.
> diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
> index 64abf865bb67..436041c57f73 100644
> --- a/drivers/ata/ahci_dwc.c
> +++ b/drivers/ata/ahci_dwc.c
> @@ -13,7 +13,6 @@
> #include <linux/kernel.h>
> #include <linux/libata.h>
> #include <linux/log2.h>
> -#include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
Since you are removing the, from what I can tell, unused syscon.h, I think
we should remove the, from what I can tell, unused linux/regmap.h include
as well.
(snip)
> static const struct of_device_id ahci_dwc_of_match[] = {
> { .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
> { .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> - { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
If we are dropping support for baikal,bt1-ahci, then I think it makes sense
to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
as well.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-02-20 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 10:42 [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-02-20 13:27 ` Niklas Cassel [this message]
2026-02-20 13:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZhhO5lMa0p41_VR@ryzen \
--to=cassel@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dlemoal@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox