From: Niklas Cassel <cassel@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: libata-eh: Fix detection of deferred qc timeouts
Date: Fri, 6 Mar 2026 10:05:31 +0100 [thread overview]
Message-ID: <aaqY24cG5ezFlEE6@ryzen> (raw)
In-Reply-To: <20260306024805.2877513-1-linux@roeck-us.net>
On Thu, Mar 05, 2026 at 06:48:05PM -0800, Guenter Roeck wrote:
> If the `ata_qc_for_each_raw()` loop finishes without finding a matching
> `scmd`, `qc` will hold a pointer to the last element examined, which is
> accociated with `i == ATA_MAX_QUEUE - 1`. This element can match
> `ap->deferred_qc`. If that happens, the condition `qc == ap->deferred_qc`
> evaluates to true despite the loop not breaking on a scmd match.
> In that case, the error handler mistakenly intercepts a command that
> completed normally after an unrelated SCSI timeout, returning a timeout
> error instead of success.
>
> [...]
Applied commit log changes from Damien and myself.
Applied to libata/linux.git (libata-for-7.0-fixes), thanks!
[1/1] ata: libata-eh: Fix detection of deferred qc timeouts
https://git.kernel.org/libata/linux/c/ee0e6e69
Kind regards,
Niklas
next prev parent reply other threads:[~2026-03-06 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 2:48 [PATCH] ata: libata-eh: Fix detection of deferred qc timeouts Guenter Roeck
2026-03-06 3:33 ` Damien Le Moal
2026-03-06 8:36 ` Niklas Cassel
2026-03-06 9:05 ` Niklas Cassel [this message]
2026-03-06 15:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaqY24cG5ezFlEE6@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox