From: Niklas Cassel <cassel@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-transport: remove redundant dynamic sysfs attributes
Date: Mon, 23 Mar 2026 11:59:39 +0100 [thread overview]
Message-ID: <acEdG2YzV7DQmutM@ryzen> (raw)
In-Reply-To: <44265829-58c8-41ad-b202-e5488892af26@gmail.com>
On Fri, Mar 20, 2026 at 11:10:59PM +0100, Heiner Kallweit wrote:
> Use the static sysfs attributes directly, this allows to significantly
> simplify the code. See attribute_container_add_attrs() for why member
> grp can be used instead of attrs.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
The sysfs attributes are still accessible from the file paths as defined in:
Documentation/ABI/testing/sysfs-ata
The sysfs attributes still have S_IRUGO file permissions.
Thus:
Tested-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2026-03-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 22:10 [PATCH] ata: libata-transport: remove redundant dynamic sysfs attributes Heiner Kallweit
2026-03-23 10:59 ` Niklas Cassel [this message]
2026-03-23 11:05 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEdG2YzV7DQmutM@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox