Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Tommy Kelly <linux@tkel.ly>
Cc: Heiko Stuebner <heiko@sntech.de>,
	linux-ide@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
	Tejun Heo <htejun@gmail.com>,
	John Garry <john.g.garry@oracle.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 0/3] ata: fix deferred QC handling for port multipliers
Date: Wed, 6 May 2026 17:00:13 +0200	[thread overview]
Message-ID: <aftXfTL98eqhpWLN@fedora> (raw)
In-Reply-To: <ec407a6d-2164-4252-90f0-0aebe8227290@tkel.ly>

Hello Tommy,

On Tue, May 05, 2026 at 05:13:41PM -0700, Tommy Kelly wrote:
> > 
> > I will also apply the FBS devicetree change (5918bf2) and test with that too.
> > 
> 
> Special thank you to Heiko for the FBS support!
> His patch setting PxCMD.FBSCP works: https://lore.kernel.org/all/20260201191804.41421-2-heiko@sntech.de/
> 
> I compiled the FBS devicetree change into u-boot (which passes the fdt to linux),
> and running on unpatched linux 6.19.12,
> FBS works, and no regressions are present.

Nice!


> Again, that is before this patch series, I see no queue_depth regression with FBS.
> As opposed to CBS which had a regression in the 6.19.x series.
> 
> I can test with this patch series + FBS if you'd like.

That would very much be appreciated if you could.

Since:
1) This series actually modifies PMP FBS behavior. Basically after this
   series, the performance should be the same as with 6.19.
   (We currently have a performance regression in mainline.)
2) I do not have a PMP with FBS available to test with.
3) I tried to reproduce your problem with a PMP with CBS, but was
   unsuccessful to reproduce it.

Thank you once again for your help!


Kind regards,
Niklas

  parent reply	other threads:[~2026-05-06 15:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 12:54 [PATCH 0/3] ata: fix deferred QC handling for port multipliers Niklas Cassel
2026-05-01 12:54 ` [PATCH 1/3] ata: libata-pmp: fix ata_pmp_qc_defer_cmd_switch() Niklas Cassel
2026-05-01 12:54 ` [PATCH 2/3] ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS Niklas Cassel
2026-05-01 12:54 ` [PATCH 3/3] ata: libata-scsi: do not needlessly defer commands when using PMP with FBS Niklas Cassel
2026-05-01 14:19 ` [PATCH 0/3] ata: fix deferred QC handling for port multipliers John Garry
2026-05-01 18:42   ` Niklas Cassel
2026-05-04  7:27     ` John Garry
2026-05-08 19:23       ` Niklas Cassel
2026-05-03  0:59 ` Tommy Kelly
2026-05-06  0:13   ` Tommy Kelly
2026-05-06  8:45     ` Heiko Stuebner
2026-05-06 15:00     ` Niklas Cassel [this message]
2026-05-06 14:52   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aftXfTL98eqhpWLN@fedora \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=heiko@sntech.de \
    --cc=htejun@gmail.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux@tkel.ly \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox