Re: [PATCH] ata: pata_arasan_cf: simplify ioremap

[Niklas Cassel <cassel@kernel.org>]

On Sun, May 10, 2026 at 12:46:07PM -0700, Rosen Penev wrote:
> Use devm_platform_get_and_ioremap_resource() to combine
> platform_get_resource, request_mem_region, and ioremap.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/ata/pata_arasan_cf.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index b1e281b64f57..d5cb88ae2b76 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -803,16 +803,6 @@ static int arasan_cf_probe(struct platform_device *pdev)
>  	irq_handler_t irq_handler = NULL;
>  	int ret;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res)
> -		return -EINVAL;
> -
> -	if (!devm_request_mem_region(&pdev->dev, res->start, resource_size(res),
> -				DRIVER_NAME)) {
> -		dev_warn(&pdev->dev, "Failed to get memory region resource\n");
> -		return -ENOENT;
> -	}
> -
>  	acdev = devm_kzalloc(&pdev->dev, sizeof(*acdev), GFP_KERNEL);
>  	if (!acdev)
>  		return -ENOMEM;
> @@ -836,14 +826,14 @@ static int arasan_cf_probe(struct platform_device *pdev)
>  		quirk |= CF_BROKEN_MWDMA | CF_BROKEN_UDMA;
>  	}
>  
> -	acdev->pbase = res->start;
> -	acdev->vbase = devm_ioremap(&pdev->dev, res->start,
> -			resource_size(res));
> -	if (!acdev->vbase) {
> +	acdev->vbase = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> +	if (IS_ERR(acdev->vbase)) {
>  		dev_warn(&pdev->dev, "ioremap fail\n");

Please remove the dev_warn().

devm_platform_get_and_ioremap_resource() itself already prints an error
on failure.

Then since it will only be a single statement, you can also remove the
braces.


Kind regards,
Niklas


> -		return -ENOMEM;
> +		return PTR_ERR(acdev->vbase);
>  	}
>  
> +	acdev->pbase = res->start;
> +
>  	acdev->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(acdev->clk)) {
>  		dev_warn(&pdev->dev, "Clock not found\n");
> -- 
> 2.54.0
>