From: Niklas Cassel <cassel@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-ide@vger.kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH v4 3/4] ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS
Date: Thu, 14 May 2026 08:30:57 +0200 [thread overview]
Message-ID: <agVsIWEOqJic87dQ@fedora> (raw)
In-Reply-To: <20260514061953.7DEA2C2BCB7@smtp.kernel.org>
On Thu, May 14, 2026 at 06:19:52AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The `ATA_DEFER_LINK_EXCL` case incorrectly uses `goto defer_qc;
> ` instead of `goto free_qc;`, causing the command to still be stored in the
> incompatible deferred workqueue.
Thank you Sashiko,
you are absolutely correct.
ATA_DEFER_LINK_PMP_CBS did correctly use "goto free_qc" in V3:
https://lore.kernel.org/linux-ide/20260508195051.188207-5-cassel@kernel.org/
I made a mistake when refactoring it and renaming it to ATA_DEFER_LINK_EXCL
in V4.
Will need to send out a V5.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-05-14 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 15:13 [PATCH v4 0/4] ata: fix deferred QC handling for port multipliers Niklas Cassel
2026-05-13 15:14 ` [PATCH v4 1/4] ata: libata-scsi: improve readability of ata_scsi_qc_issue() Niklas Cassel
2026-05-13 15:14 ` [PATCH v4 2/4] ata: libata-scsi: do not use the deferred QC feature for ATA_DEFER_PORT Niklas Cassel
2026-05-13 15:14 ` [PATCH v4 3/4] ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS Niklas Cassel
2026-05-14 6:19 ` sashiko-bot
2026-05-14 6:30 ` Niklas Cassel [this message]
2026-05-13 15:14 ` [PATCH v4 4/4] ata: libata-scsi: do not needlessly defer commands when using PMP with FBS Niklas Cassel
2026-05-14 10:05 ` sashiko-bot
2026-05-14 11:08 ` Niklas Cassel
2026-05-14 4:09 ` [PATCH v4 0/4] ata: fix deferred QC handling for port multipliers Tommy Kelly
2026-05-14 4:42 ` Tommy Kelly
2026-05-14 6:42 ` Niklas Cassel
2026-05-14 6:48 ` Tommy Kelly
2026-05-14 6:49 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agVsIWEOqJic87dQ@fedora \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox