From: Niklas Cassel <cassel@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-ide@vger.kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH v3] ata: libata: Document when host->eh_mutex should be held
Date: Thu, 28 May 2026 08:57:40 +0200 [thread overview]
Message-ID: <ahfnZEfc1zASNzZI@ryzen> (raw)
In-Reply-To: <20260527205711.BCA141F000E9@smtp.kernel.org>
Hello Bart,
On Wed, May 27, 2026 at 08:57:11PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>
> New issues:
> - [Low] Missing '&' operator in lock capability expression for `__acquires` and `__releases` annotations on `ata_eh_acquire` and `ata_eh_release`.
Is this review comment are valid?
> - [Low] The `ata_dummy_error_handler` function is missing the `__must_hold(&ap->host->eh_mutex)` annotation.
I don't see any downside of also just annotating ata_dummy_error_handler().
Kind regards,
Niklas
next prev parent reply other threads:[~2026-05-28 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 20:25 [PATCH v3] ata: libata: Document when host->eh_mutex should be held Bart Van Assche
2026-05-27 20:55 ` Niklas Cassel
2026-05-27 21:09 ` Bart Van Assche
2026-05-27 20:57 ` sashiko-bot
2026-05-28 6:57 ` Niklas Cassel [this message]
2026-05-27 22:28 ` Damien Le Moal
2026-05-28 6:58 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahfnZEfc1zASNzZI@ryzen \
--to=cassel@kernel.org \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox