Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: yangxingui <yangxingui@huawei.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	linux-kernel@vger.kernel.org, liuyonglong@huawei.com,
	kangfenglong@huawei.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-sata: retry hardreset when device detected but PHY not established
Date: Thu, 28 May 2026 09:09:54 +0200	[thread overview]
Message-ID: <ahfqQtalkjBuMa9f@ryzen> (raw)
In-Reply-To: <b241ef3f-d476-12f2-2862-ca95ff509046@huawei.com>

Hello Xingui,

On Thu, May 28, 2026 at 03:01:39PM +0800, yangxingui wrote:
> 
> Latest update: The issue we are currently facing is that the SATA host side
> is continuously waiting for the disk to return the COMWAKE primitive. From
> the SATA analyzer, it can be seen that the disk has already returned the
> COMWAKE primitive. This may be related to poor COMWAKE signal quality,
> causing the host to fail to recognize it. Performing a hard reset might be
> able to fix the issue.

I'm a little confused. In your previous update you said that the issue had
been resolved.

Now you say that an additional hard reset (COMRESET) "might be able" to
fix the issue.
That does not sound like you have actually verified if it does so or not.

Perhaps you can try implementing my suggestion in:
https://lore.kernel.org/linux-ide/afMgoFBFPWR0f4gK@ryzen/

which does an additional hard reset (COMRESET).

But please only send out a patch if you have actually verified that the
suggestion actually resolves your issue.


Kind regards,
Niklas

  reply	other threads:[~2026-05-28  7:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260425060447.1312763-1-yangxingui@huawei.com>
     [not found] ` <e8d237bc-7191-4881-924b-86a34ff0f3b9@kernel.org>
2026-04-27  1:51   ` [PATCH] ata: libata-sata: retry hardreset when device detected but PHY not established yangxingui
2026-04-27  4:45     ` Damien Le Moal
2026-04-29  1:14       ` yangxingui
2026-04-29  1:36         ` Damien Le Moal
2026-04-29  7:01           ` yangxingui
2026-04-30  8:46             ` Niklas Cassel
2026-04-30  9:28               ` Niklas Cassel
2026-05-06  2:23                 ` yangxingui
2026-05-28  7:01               ` yangxingui
2026-05-28  7:09                 ` Niklas Cassel [this message]
2026-05-29  1:21                   ` yangxingui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahfqQtalkjBuMa9f@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=kangfenglong@huawei.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox