From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D93402442;
	Thu,  4 Jun 2026 11:31:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1780572713; cv=none; b=JxmsNssTps+w6iFSjDA3RPZldXD1jZ/02Em2gjQHPfYfcxk3rQDgRuoDUqkDWm2nINLOI/8EA1G4fg1KIOFD4eC8LLKLxOJjCknEJ4ARdY1pPVTfhwogm94JZkPE0/UrSit0JSEWiGNeHUZPOUK0jhPQKhbO61DAtNuGhIYDbQM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1780572713; c=relaxed/simple;
	bh=bsa1jnN9EKkBwXlgr8xmI7rOSZf5eJ5lbPwcqhxOq30=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=FzJx0EUYYd/BfjiFeJUz3TAptWS0yx+fMsaWbhP8KCBXPuZ4o3EpFAlobYGeAB87Tueh5SJqv/UUHs4RJUaKbBrJ2yeNrMhDwwyiJvusFYGu5Gck6jsVE3PyDaoIR6OCSJhTNJ+XBLxTtI65mmjPm3PzIWEK2xbMbUr2k6XnYIg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E7/qztfG; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E7/qztfG"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC5FB1F00893;
	Thu,  4 Jun 2026 11:31:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1780572712;
	bh=AIzXNElv+eVz+Fw+Twv7xF83NqwaQAYmHeMAronAqWE=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=E7/qztfGUd2WYES2vdR4LejTuRUMtP7fi8vsZaeGe7wh3E7uymM+7ULRqOuHv0zjM
	 Mdsfhkz7cQhdsWtcwrwhoqRnX/UFvquE0c0skBUnrsLY8gyNKUOxSgq+3wpzVhq1FN
	 UFFzEUF4jM+cTeoeNfmOK8FycGv4oAvQNKeXqe78glhWlilVnL0g9zTvDxlsIzJOM+
	 xc323UeBu1XV4TrEM382xBlXdoh3g3Fs+d8+2blbNmXKWGhYd9IHYvXZRRkpx+qmyj
	 db8O+bL1+CEfptZ60CCkyL9V/B3loYpfhhYjEpMufVrEp844tgZdhYT2iAIPUuNtF7
	 r29Ofu/CcjRTw==
Date: Thu, 4 Jun 2026 13:31:48 +0200
From: Niklas Cassel <cassel@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: dlemoal@kernel.org, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_brcm: fix reset refcount leak in
 brcm_ahci_resume()
Message-ID: <aiFiJJPOQgQABuXm@ryzen>
References: <20260603102420.3735032-1-vulab@iscas.ac.cn>
 <aiFNiWf7bs2pmPFh@ryzen>
Precedence: bulk
X-Mailing-List: linux-ide@vger.kernel.org
List-Id: <linux-ide.vger.kernel.org>
List-Subscribe: <mailto:linux-ide+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-ide+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aiFNiWf7bs2pmPFh@ryzen>

On Thu, Jun 04, 2026 at 12:03:53PM +0200, Niklas Cassel wrote:

(snip)

> The documentation for reset_control, explicitly says not to do this:
> https://github.com/torvalds/linux/blob/v7.1-rc6/drivers/reset/core.c#L365-L366
> 
> And in libahci_platform.c, we always do either:
> return reset_control_rearm() or return reset_control_reset():
> https://github.com/torvalds/linux/blob/v7.1-rc6/drivers/ata/libahci_platform.c#L188-L193

I realize that I am stupid...

The code is doing it on two different reset handles.

My comment that the cleanup in brcm_ahci_resume() should match that in
brcm_ahci_resume() probe still stands.

i.e. you should also add a call to:
reset_control_assert(priv->rcdev_ahci);

And you should do it after disabling clocks, just as brcm_ahci_resume().


Kind regards,
Niklas