Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: linux-ide@vger.kernel.org
Subject: potential null deref in drivers/ide/ide-io.c start_request().
Date: Sun, 19 Jul 2009 14:43:49 +0300 (EAT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0907171322100.12306@bicker> (raw)

Hello,

I am testing a code checker (http://repo.or.cz/w/smatch.git) and it found 
an issue in ide-io.c

The case where rq->rq_disk is null and blk_special_request(rq) returns 
zero on line 356 would cause an oops on line 367.

drivers/ide/ide-io.c
   356                  } else if (!rq->rq_disk && blk_special_request(rq))
   357                          /*
   358                           * TODO: Once all ULDs have been modified to
   359                           * check for specific op codes rather than
   360                           * blindly accepting any special request, the
   361                           * check for ->rq_disk above may be replaced
   362                           * by a more suitable mechanism or even
   363                           * dropped entirely.
   364                           */
   365                          return ide_special_rq(drive, rq);
   366  
   367                  drv = *(struct ide_driver **)rq->rq_disk->private_data;

regards,
dan carpenter

                 reply	other threads:[~2009-07-19 12:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0907171322100.12306@bicker \
    --to=error27@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox