From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-ide@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jgarzik@pobox.net
Subject: Re: libata: make parallel port scan a per-host opt-in feature
Date: Fri, 9 Jan 2009 16:58:08 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0901091657090.6528@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0901091655530.6528@localhost.localdomain>
On Fri, 9 Jan 2009, Linus Torvalds wrote:
>
>
> On Fri, 9 Jan 2009, Arjan van de Ven wrote:
> >
> > + if (!hpriv->cap & HOST_CAP_SSS)
> > + host->flags |= ATA_HOST_PARALLEL_SCAN;
> > +
>
> I don't think that does what you think it does.
And furthermore I'm surprised gcc doesn't warn about it. It would seem to
be an obvious thing to warn about. I'll see what a sparse warning would
look like.
Linus
next prev parent reply other threads:[~2009-01-10 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 0:14 libata: make parallel port scan a per-host opt-in feature Arjan van de Ven
2009-01-10 0:56 ` Linus Torvalds
2009-01-10 0:58 ` Linus Torvalds [this message]
2009-01-10 1:00 ` Linus Torvalds
2009-01-10 1:00 ` Arjan van de Ven
2009-01-10 21:26 ` [PATCH 1/2] libata: Add a per-host flag to opt-in into parallel port probes Arjan van de Ven
2009-01-10 21:27 ` [PATCH 2/2] libata: only ports >= 0 need to synchronize Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901091657090.6528@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=jgarzik@pobox.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox