From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: libata: make parallel port scan a per-host opt-in feature Date: Fri, 9 Jan 2009 17:00:47 -0800 (PST) Message-ID: References: <20090109161455.08d5a54c@infradead.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:32969 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213AbZAJBA4 (ORCPT ); Fri, 9 Jan 2009 20:00:56 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Arjan van de Ven Cc: linux-ide@vger.kernel.org, Linux Kernel Mailing List , jgarzik@pobox.net On Fri, 9 Jan 2009, Linus Torvalds wrote: > > On Fri, 9 Jan 2009, Linus Torvalds wrote: > > > > On Fri, 9 Jan 2009, Arjan van de Ven wrote: > > > > > > + if (!hpriv->cap & HOST_CAP_SSS) > > > + host->flags |= ATA_HOST_PARALLEL_SCAN; > > > + > > > > I don't think that does what you think it does. > > And furthermore I'm surprised gcc doesn't warn about it. It would seem to > be an obvious thing to warn about. I'll see what a sparse warning would > look like. Heh. sparse already warns: warning: dubious: !x & y although I'm not sure that's necessarily the most readable warning ever. Linus