From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 09/12] irq: implement IRQ expecting Date: Thu, 17 Jun 2010 13:12:52 +0200 (CEST) Message-ID: References: <1276443098-20653-1-git-send-email-tj@kernel.org> <1276443098-20653-10-git-send-email-tj@kernel.org> <20100616204854.4b036f87@infradead.org> <4C19DA64.8000409@kernel.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.tglx.de ([62.245.132.106]:33129 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362Ab0FQLQj (ORCPT ); Thu, 17 Jun 2010 07:16:39 -0400 In-Reply-To: <4C19DA64.8000409@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Arjan van de Ven , mingo@elte.hu, bphilips@suse.de, yinghai@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, jeff@garzik.org, linux-ide@vger.kernel.org, stern@rowland.harvard.edu, gregkh@suse.de, khali@linux-fr.org On Thu, 17 Jun 2010, Tejun Heo wrote: > Hello, Arjan. > > On 06/17/2010 05:48 AM, Arjan van de Ven wrote: > > On Sun, 13 Jun 2010 17:31:35 +0200 > > Tejun Heo wrote: > >> + */ > >> +void expect_irq(struct irq_expect *exp) > > > > I would like to suggest an (optional) argument to this with a duration > > within which to expect an interrupt.... > > > > that way in the backend we can plumb this also into the idle handler > > for C state selection... > > Hmmm.... oh, I see. Wouldn't it be much better to use moving avg of > IRQ durations instead of letting the driver specify it? Drivers are > most likely to just hard code it and It's never gonna be accurate. Right, but that's probably more accurate than the core code heuristics ever will be. Thanks, tglx