From: Keith Busch <keith.busch@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Keith Busch <keith.busch@intel.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: SATL compliance for Inquiry Product Revision
Date: Thu, 1 May 2014 10:44:59 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1405011011010.5666@AMR> (raw)
In-Reply-To: <20140501151510.GF31611@htj.dyndns.org>
On Thu, 1 May 2014, Tejun Heo wrote:
> On Tue, Apr 29, 2014 at 01:25:24PM -0600, Keith Busch wrote:
>> @@ -1993,7 +1993,10 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf)
>> memcpy(rbuf, hdr, sizeof(hdr));
>> memcpy(&rbuf[8], "ATA ", 8);
>> ata_id_string(args->id, &rbuf[16], ATA_ID_PROD, 16);
>> - ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
>> + if (args->id[25] == 0x2020 && args->id[26] == 0x2020)
>
> Maybe strncmp(" ") is more readable? And can you please add some
> comment explaining what's going on?
Sounds good. Will do a v2 with that.
>> + ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
>> + else
>> + ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV + 2, 4);
>
> So, this would change the behavior for devices which were reporting
> stuff in ATA_ID_FW_REV. Prolly no biggiee.
Yep, though many devices do pad with spaces so it won't change for
those. I did do a sanity check on both kinds to make sure it looked right.
prev parent reply other threads:[~2014-05-01 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 19:25 [PATCH] ata: SATL compliance for Inquiry Product Revision Keith Busch
2014-05-01 15:15 ` Tejun Heo
2014-05-01 16:44 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1405011011010.5666@AMR \
--to=keith.busch@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox