Re: [PATCH 2/2] ata: libata: Correct libata.force parameter documentation

[Niklas Cassel <cassel@kernel.org>]

On Fri, Sep 18, 2026 at 02:40:33PM +0200, Niklas Cassel wrote:
> Align the documented libata.force options with their implementation.
> The force table accepts PIO modes 0 through 6, not mode 7, and ncqati
> controls NCQ generally rather than only queued TRIM.
> 
> The max_sec_1024 and max_sec_lba48 options only set transfer size
> limits. Remove the misleading claim that they can also clear them.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 33cd30996e47..24459f7ff810 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3491,7 +3491,7 @@ Kernel parameters
>  
>  			* SATA link speed limit: 1.5Gbps or 3.0Gbps.
>  
> -			* Transfer mode: pio[0-7], mwdma[0-4] and udma[0-7].
> +			* Transfer mode: pio[0-6], mwdma[0-4] and udma[0-7].
>  			  udma[/][16,25,33,44,66,100,133] notation is also
>  			  allowed.
>  
> @@ -3509,7 +3509,7 @@ Kernel parameters
>  
>  			* [no]ncqtrim: Enable or disable queued DSM TRIM.
>  
> -			* [no]ncqati: Enable or disable NCQ trim on ATI chipset.
> +			* [no]ncqati: Enable or disable NCQ on ATI chipsets.

Hmm.. I guess we could theoretically remove the [no]ncqati parameter from
libata.force.
If a user wants to enable/disable ncq, they can use the [no]ncq libata.force
parameter.

However, since this libata.force kernel parameter already exists, I guess it
might actually be used by someone, so we can't really remove it without
potentially breaking existing setups, so I guess the easiest thing is just
to keep it, even if it is not strictly needed.


Kind regards,
Niklas