Re: [PATCH] libata: Fix wrong HPA horkage

[Niklas Cassel <cassel@kernel.org>]

On Tue, Oct 13, 2026 at 07:21:46AM +0300, Ioannis Barkas wrote:
>  Code wrongly filters disks by their serial numbers
> 
> Fixes: 16c55b038033 (\libata: implement BROKEN_HPA horkage and apply it to affected drives")

This should have been V2, as you have already send a patch for this.

Like we commented on your V1:
https://lore.kernel.org/linux-ide/40630ece-de85-48a5-8683-93be32e5d644@kernel.org/

The Fixes tag is corrupted, there should be no backslash.


> Link: https://bugzilla.kernel.org/show_bug.cgi?id=8888
> Signed-off-by: Ioannis Barkas jnyb.de@gmail.com
> Signed-off-by: Nick Barkas nickbgrk@gmail.com
> ---
>  drivers/ata/libata-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 59e87b987d..b23e1c3e4c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4248,8 +4248,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  
>  	/* devices which puke on READ_NATIVE_MAX */
>  	{ "HDS724040KLSA80",	"KFAOA20N",	ATA_QUIRK_BROKEN_HPA },
> -	{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
> -	{ "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
> +	{ "WDC WD3200JD-00KLB0", "08.05J08", ATA_QUIRK_BROKEN_HPA },
> +	{ "WDC WD2500JD-00HBB0", "08.02D08", ATA_QUIRK_BROKEN_HPA },

You need to explain why the previous FW revision in not correct.

I think the simplest thing here is to simply omit the FW version field,
i.e. change it to NULL.

However, as pointed out by Sashiko on V1:
https://lore.kernel.org/linux-ide/20260913140806.546C91F000FF@smtp.kernel.org/

There is already a wildcarded entry:
    { "WDC WD3200JD-*",     NULL,   ATA_QUIRK_WD_BROKEN_LPM },

So you should probably drop the "WDC WD3200JD-00KLB0" entry,
and modify the "WDC WD3200JD-*" entry to have quirks:
ATA_QUIRK_BROKEN_HPA | ATA_QUIRK_WD_BROKEN_LPM


Kind regards,
Niklas