Re: [PATCH] ata: pata_atiixp allow maximum UDMA speed

[Niklas Cassel <cassel@kernel.org>]

On Tue, Oct 13, 2026 at 07:30:16AM +0300, Ioannis Barkas wrote:
> Enable UDMA 6 for compatible IDE hosts, tested on SB600 & SB700
> using ATA133 HDDs & SSDs. SSDs can exceed now 100MB/s

This commit log is a bit short. Please provide some more information.

You commit log mentions SB600 & SB700, but the code comment mentions
SB300.


> 
> Signed-off-by: Ioannis Barkas jnyb.de@gmail.com
> Signed-off-by: Nick Barkas nickbgrk@gmail.com

The email addresses in this patch, and in all your other patches,
are missing corrupt. The format is:

Signed-off-by: Firstname Lastname <email@address.com>

i.e. you are missing <> around the email address.


> ---
>  drivers/ata/pata_atiixp.c | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
> index 4c612f9543..74ef9195bd 100644
> --- a/drivers/ata/pata_atiixp.c
> +++ b/drivers/ata/pata_atiixp.c
> @@ -279,8 +279,26 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
>  		.udma_mask = ATA_UDMA5,
>  		.port_ops = &atiixp_port_ops
>  	};
> +	static const struct ata_port_info info_ata133 = {
> +		.flags = ATA_FLAG_SLAVE_POSS,
> +		.pio_mask = ATA_PIO4,
> +		.mwdma_mask = ATA_MWDMA12_ONLY,
> +		.udma_mask = ATA_UDMA6,
> +		.port_ops = &atiixp_port_ops
> +	};
>  	const struct ata_port_info *ppi[] = { &info, &info };
>  
> +	/* SB300 and newer: UDMA6 */
> +	switch (pdev->device) {
> +	case PCI_DEVICE_ID_ATI_IXP300_IDE:
> +	case PCI_DEVICE_ID_ATI_IXP400_IDE:
> +	case PCI_DEVICE_ID_ATI_IXP600_IDE:
> +	case PCI_DEVICE_ID_ATI_IXP700_IDE:
> +	case PCI_DEVICE_ID_AMD_HUDSON2_IDE:
> +		ppi[0] = ppi[1] = &info_ata133;
> +		break;
> +	}
> +
>  	/* SB600 doesn't have secondary port wired */
>  	if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
>  		ppi[1] = &ata_dummy_port_info;
> @@ -314,7 +332,7 @@ static struct pci_driver atiixp_pci_driver = {
>  module_pci_driver(atiixp_pci_driver);
>  
>  MODULE_AUTHOR("Alan Cox");
> -MODULE_DESCRIPTION("low-level driver for ATI IXP200/300/400");
> +MODULE_DESCRIPTION("low-level driver for ATI IXP200/300/400, AMD SB600/700 series and Hudson-2");

This is a separate logical change, please drop it.

As we can see from the context above:

/* SB600 doesn't have secondary port wired */

The driver already supports SB600 in PATA mode, even though it was not
explicitly mentioned in the module description.

I don't see why we would need to change it now.


Kind regards,
Niklas