Re: [PATCH] [PATCH v3] ata: libata-core: Correct HPA horkage

[Niklas Cassel <cassel@kernel.org>]

On Tue, Oct 13, 2026 at 11:19:26PM +0300, Ioannis Barkas wrote:
> Code wrongly detects disks using 2 specific serial numbers
> Use their firmware to detect whole family of affected disks
> 
> Fixes: 16c55b038033 (libata: implement BROKEN_HPA horkage and apply it to affected drives")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=8888
> Signed-off-by: <Ioannis Barkas jnyb.de@gmail.com>
> Signed-off-by: <Nick Barkas nickbgrk@gmail.com>

The correct format is:
Signed-off-by: Nick Barkas <nickbgrk@gmail.com>

It is automatically added when you do: git commit -s
You should not need to modify it manually.


Also, the final Signed-off-by should be the same as the sender.
That is not the case here.

Two Signed-off-by directly after each other is only used if you took the
patch authored by someone else, and submitted it unchanged.

If you were two people to develop the patch together, the correct tag to
use is Co-developed-by (in addition to Signed-off-by from both), see:
https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by



> ---
>  drivers/ata/libata-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 59e87b987d..b23e1c3e4c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4248,8 +4248,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  
>  	/* devices which puke on READ_NATIVE_MAX */
>  	{ "HDS724040KLSA80",	"KFAOA20N",	ATA_QUIRK_BROKEN_HPA },
> -	{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
> -	{ "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
> +	{ "WDC WD3200JD-00KLB0", "08.05J08", ATA_QUIRK_BROKEN_HPA },
> +	{ "WDC WD2500JD-00HBB0", "08.02D08", ATA_QUIRK_BROKEN_HPA },

Where did you get this firmware versions from?

As I stated in:
https://lore.kernel.org/linux-ide/as6GuZaRvJFbxMgK@ryzen/

I would prefer if you simply dropped these entries, such that the existing
wildcard entries (which already match these devices) are the only ones used.


Kind regards,
Niklas