Re: [PATCH] ata: libata-core: Add NOLPM/NONCQ/1.5Gbps quirk for PNY 1TB SATA SSD

[Niklas Cassel <cassel@kernel.org>]

On Wed, Oct 28, 2026 at 03:54:34PM +0100, Thierry Vignaud wrote:
> Without that, I get the errors below.
> For a year, I workaround it by disabling NCQ & reducing the speed by
> booting with "libata.force=1:3.0Gbps,1:noncq".
> It tried out disabling LPM only but I was still able to see errors.

The body should be readable without the subject, so please
rephrase "Without that,".


>
> Related: bko#222187

If you want to reference this, use the Link or Closes tag, e.g.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=222187

See:
https://docs.kernel.org/process/submitting-patches.html


> 
> v3:
> - add firmware revision check
> v2:
> - remove firmware revision from SSD name
> - drop speed to 1.5Gbs (as there's no 3.0Gbps quirk)
> - disable NCQ altogether (else we still see the errors from times to
>   times)

The changelog should be after the "---" line, before the diffstat, see e.g.:
https://lore.kernel.org/linux-ide/179405688421.943559.6118296661484264171.b4-ty@kernel.org/T/#t


The patch is missing v3 in the subject, so right now it has the same subject
as the previous patches, which is incorrectly putting all versions is the same
thread:
https://lore.kernel.org/linux-ide/CAHSMvrFXEnsLKF_BSYWz=V=ht6++RocuHJO0tkhUmPcHHvXp5A@mail.gmail.com/T/#t

You need to generate it using e.g.:

$ git format-patch -v 3

Which will generate the proper subject.


> ---
>  drivers/ata/libata-core.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index dadcaf9ff462..cde9d367c20f 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4398,6 +4398,13 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
>  	/* PNY CS900 (Phison PS3111-S11, DRAM-less) drops the link on DIPM */
>  	{ "PNY CS900 1TB SSD",		NULL,	ATA_QUIRK_NOLPM },
>  
> +	/* PNY CS900 (variant) drops the link on DIPM and NCQ
> +	 * This covers only the 1TB variant but other sizes are affected
> +	 * according to forum posts */
> +	{ "PNY 1TB SATA SSD",		"H220916a",	ATA_QUIRK_NOLPM |
> +							ATA_QUIRK_1_5_GBPS |
> +							ATA_QUIRK_NONCQ },

Does this drive really need 1.5 Gbps quirk?
Right now we only have 2 drives with the ATA_QUIRK_1_5_GBPS quirk.

Ideally, it would be nice if we could just have a single quirk.
If for some reason a single quirk is not sufficient, then two quirks
is fine... But three quirks?

I'm not saying that it is impossible, but it is very rare that we have
seen a drive that requires three different quirks.


Kind regards,
Niklas