From: Niklas Cassel <cassel@kernel.org>
To: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
Cc: dlemoal@kernel.org, szczepan.durawa@intel.com,
szymon.durawa@linux.intel.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID
Date: Thu, 29 Oct 2026 15:26:45 +0100 [thread overview]
Message-ID: <auNXpco9zBLtG59w@ryzen> (raw)
In-Reply-To: <20261029140004.6991-1-romanx.gardzinski@linux.intel.com>
On Thu, Oct 29, 2026 at 03:00:03PM +0100, Roman Gardzinski wrote:
> When the Intel Nova Lake SATA controller is configured in RAID mode (rather
> than AHCI), the generic entry in ahci_pci_tbl which matches any device with
> the PCI class code for AHCI, is not sufficient, since the SATA controller
> in RAID mode uses a different PCI class code.
>
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Niklas Cassel <cassel@kernel.org>
>
> Suggested-by: Szczepan Durawa <szczepan.durawa@intel.com>
> Reviewed-by: Szymon Durawa <szymon.durawa@linux.intel.com>
> Signed-off-by: Roman Gardzinski <romanx.gardzinski@linux.intel.com>
> ---
> v1 -> v2:
> - update RAID entry in ahci_pci_tbl to board_ahci from board_ahci_pcs_quirk
> - update commit description
>
> drivers/ata/ahci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 9b8c0935001c..cee67c64fbea 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -280,6 +280,10 @@ static const struct ata_port_info ahci_port_info[] = {
> static const struct pci_device_id ahci_pci_tbl[] = {
> /* Intel */
> {
> + /* Nova Lake PCH-S RAID */
> + PCI_VDEVICE(INTEL, 0x6e66),
> + .driver_data = board_ahci,
> + }, {
> /* Comet Lake PCH-H RAID */
> PCI_VDEVICE(INTEL, 0x06d6),
> .driver_data = board_ahci_pcs_quirk,
> --
> 2.53.0
>
Looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
prev parent reply other threads:[~2026-10-29 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 14:00 [PATCH v2] ATA: ahci: Add Intel PCH-S RAID device ID Roman Gardzinski
2026-10-29 14:26 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auNXpco9zBLtG59w@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romanx.gardzinski@linux.intel.com \
--cc=szczepan.durawa@intel.com \
--cc=szymon.durawa@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox