From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: SATA: Fine-tuning for two function implementations
Date: Sat, 29 Apr 2017 10:30:29 +0200 [thread overview]
Message-ID: <b2a3953b-8e8f-fea1-8a04-9ecafdf31102@users.sourceforge.net> (raw)
In-Reply-To: <20170428215334.GH22354@htj.duckdns.org>
> Hmmm, allocs -> callocs. Are these actually beneficial? If so, why?
> Because one multiplication is rolled into the call?
Did the previous size calculations contain the general possibility for
integer overflows?
https://cwe.mitre.org/data/definitions/190.html
* Will the computed values usually stay within the limits of the used
data types so far?
* How much do you care for corresponding checks and source code annotations
by functions like “devm_kcalloc”?
Regards,
Markus
next prev parent reply other threads:[~2017-04-29 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 20:00 [PATCH 0/3] SATA: Fine-tuning for two function implementations SF Markus Elfring
2017-04-18 20:01 ` [PATCH 1/3] ata: libahci: Use kcalloc() in ahci_platform_get_resources() SF Markus Elfring
2017-04-18 20:02 ` [PATCH 2/3] ata: libahci: Use devm_kcalloc() " SF Markus Elfring
2017-04-18 20:03 ` [PATCH 3/3] sata_mv: Use devm_kcalloc() in mv_platform_probe() SF Markus Elfring
2017-04-28 21:53 ` [PATCH 0/3] SATA: Fine-tuning for two function implementations Tejun Heo
2017-04-29 8:30 ` SF Markus Elfring [this message]
[not found] ` <CGME20170511150136epcas5p4549f5ae51303ef506c0f7f91b5dd1317@epcas5p4.samsung.com>
2017-05-11 15:01 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a3953b-8e8f-fea1-8a04-9ecafdf31102@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).