Re: [PATCH RFC v2 07/18] libata-scsi: Add ata_internal_queuecommand()

John Garry
2022-06-13T09:41:30Z

On 13/06/2022 08:16, Damien Le Moal wrote:
>> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
>> index baac35dd17ca..b2702ab0183b 100644
>> --- a/drivers/ata/libata-scsi.c
>> +++ b/drivers/ata/libata-scsi.c
>> @@ -1114,6 +1114,20 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev)
>> return 0;
>> }
>>
>> +int ata_internal_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmd)
> ata_scsi_internal_queuecommand()

ok

>
> But given that this is used for the .reserved_queuecommand() method, I
> would call it ata_scsi_reserved_queuecommand().

I did mention somewhere that I continued to use the term "internal" as
that is what libata already uses, but I can change it.

>
>> +{
>> + struct ata_port *ap;
>> + int res;
>> +
>> + ap = ata_shost_to_port(shost);
> You can move this to ap declaration.
>
> struct ata_port *ap = ata_shost_to_port(shost);

ok

>
>> + spin_lock_irq(ap->lock);
> spin_lock_irqsave() ?

Right

>
>> + res = ata_sas_queuecmd(scmd, ap);
>> + spin_unlock_irq(ap->lock);
>> +
>> + return res;

Thanks,
John