From: Damien Le Moal <dlemoal@kernel.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Mikael Pettersson" <mikpelinux@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ata: Consistently define pci_device_ids using named initializers
Date: Fri, 12 Jun 2026 16:42:03 +0900 [thread overview]
Message-ID: <bc1234d8-c202-4418-b85f-7672c667ceb1@kernel.org> (raw)
In-Reply-To: <cover.1781248922.git.ukleinek@kernel.org>
On 6/12/26 16:35, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
>
> (implicit) v1 of this series can be found at
> https://lore.kernel.org/linux-ide/20260430170612.510869-2-u.kleine-koenig@baylibre.com
>
> Damien asked to rework the patch adding more line breaks to make the
> resulting lines shorter. I didn't rewrap all arrays, only those that
> appeared too long to me; the longest line I kept is:
>
> + { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), .driver_data = GENERIC },
>
> which is short enough to not trigger a checkpatch warning.
Yeah. But we tend to stick with the old 80-char max lines.
But no big deal as this was already a long line anyway.
That said, it is a chance to rewrap that too. If you are willing to send a v3,
we'll take it :)
Nevertheless, overall, very nice cleanup. Thanks for doing it.
For the series:
Reviewed-by: Damien Le Moal <dlemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-06-12 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 7:35 [PATCH v2 0/2] ata: Consistently define pci_device_ids using named initializers Uwe Kleine-König (The Capable Hub)
2026-06-12 7:35 ` [PATCH v2 1/2] ata: Drop unused assignments of pci_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-06-12 7:35 ` [PATCH v2 2/2] ata: Use named initializers for pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-06-12 7:42 ` Damien Le Moal [this message]
2026-06-12 10:58 ` [PATCH v2 0/2] ata: Consistently define pci_device_ids using named initializers Niklas Cassel
2026-06-12 11:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1234d8-c202-4418-b85f-7672c667ceb1@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpelinux@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox